fix tests that involve dates fail when OS culture has 24 hours format (…

…#506) * fix tests that involve dates fail when OS culture has 24 hours format * update changelog * Update CHANGELOG.md Move merge 'fix tests that involve dates fail when OS culture has 24 hours format' to next unpublished version
MethodsAndPractices · May 13, 2023 · bf8f488 · bf8f488
1 parent b237a2e
commit bf8f488
Show file tree

Hide file tree

Showing 11 changed files with 25 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 7.12.0
 
+Merged [Pull Request](https://github.com/MethodsAndPractices/vsteam/pull/506) from [Miguel Nieto](https://github.com/mnieto) the following:
+- fix tests that involve dates fail when OS culture has 24 hours format
+
 Merged [Pull Request](https://github.com/MethodsAndPractices/vsteam/pull/495) from [Seva Alekseyev](https://github.com/sevaa) the following:
 - Added the command Set-VSTeamVariableGroupVariable, which assigns a value to a single variable in a variable group,
 creating one if needed. [#423](https://github.com/MethodsAndPractices/vsteam/issues/423)

diff --git a/Tests/library/CommonTests.cs b/Tests/library/CommonTests.cs
@@ -32,7 +32,7 @@ public void MoveProperties_StringToDateTime()
          Common.MoveProperties(target, source);
 
          // Assert
-         Assert.AreEqual("8/27/2020 10:37:32 am", target.CreatedOn.ToUniversalTime().ToString("M/d/yyyy h:mm:ss tt").ToLower());
+         Assert.AreEqual("8/27/2020 10:37:32 am", target.CreatedOn.ToUniversalTime().ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower());
       }
    }
 }
diff --git a/Tests/library/Provider/BuildDefinitionTests.cs b/Tests/library/Provider/BuildDefinitionTests.cs
@@ -34,7 +34,7 @@ public void BuildDefinition_Constructor_2017_Git()
          Assert.AreEqual("projectCollection", actual.JobAuthorizationScope, "JobAuthorizationScope");
          Assert.AreEqual("$(date:yyyyMMdd)$(rev:.r)", actual.BuildNumberFormat, "BuildNumberFormat");
 
-         Assert.AreEqual("8/23/2020 3:12:41 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
+         Assert.AreEqual("8/23/2020 3:12:41 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
 
          Assert.IsNotNull(actual.Options, "Options");
          Assert.AreEqual(4, actual.Options.Count, "Options.Count");
@@ -103,7 +103,7 @@ public void BuildDefinition_Constructor_2017_Tfvc()
          Assert.IsNull(actual.GitRepository, "GitRepository");
          Assert.IsNotNull(actual.RetentionRules, "RetentionRules");
 
-         Assert.AreEqual("8/23/2020 10:30:31 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
+         Assert.AreEqual("8/23/2020 10:30:31 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
 
          Assert.AreEqual(5, actual.JobCancelTimeoutInMinutes, "JobCancelTimeoutInMinutes");
          Assert.AreEqual("projectCollection", actual.JobAuthorizationScope, "JobAuthorizationScope");
@@ -145,7 +145,7 @@ public void BuildDefinition_Constructor_2018()
          Assert.IsNotNull(actual.GitRepository, "GitRepository");
          Assert.IsNotNull(actual.RetentionRules, "RetentionRules");
 
-         Assert.AreEqual("8/23/2020 3:16:22 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
+         Assert.AreEqual("8/23/2020 3:16:22 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
 
          Assert.AreEqual(5, actual.JobCancelTimeoutInMinutes, "JobCancelTimeoutInMinutes");
          Assert.AreEqual("projectCollection", actual.JobAuthorizationScope, "JobAuthorizationScope"); 
@@ -205,7 +205,7 @@ public void BuildDefinition_Constructor_AzD_Classic()
 
          Assert.IsNull(actual.Demands, "Demands");
 
-         Assert.AreEqual("9/16/2019 2:34:16 am", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
+         Assert.AreEqual("9/16/2019 2:34:16 am", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
 
          // Not on this build def
          Assert.AreEqual(null, actual.BuildNumberFormat, "BuildNumberFormat");
@@ -266,7 +266,7 @@ public void BuildDefinition_Constructor_AzD_YAML()
 
          Assert.IsNull(actual.Demands, "Demands");
 
-         Assert.AreEqual("9/25/2019 8:55:54 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
+         Assert.AreEqual("9/25/2019 8:55:54 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
 
          // Not on this build def
          Assert.AreEqual(0, actual.JobCancelTimeoutInMinutes, "JobCancelTimeoutInMinutes");

diff --git a/Tests/library/Provider/BuildTests.cs b/Tests/library/Provider/BuildTests.cs
@@ -30,7 +30,7 @@ public void Build_Constructor()
          Assert.AreEqual("PTracker-CI", actual.DefinitionName, "DefinitionName");
          Assert.AreEqual("Donovan Brown", actual.RequestedByUser, "RequestedByUser");
          Assert.AreEqual("Donovan Brown", actual.RequestedForUser, "RequestedForUser");
-         Assert.AreEqual("11/14/2019 12:49:37 am", actual.StartTime?.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "startTime");
+         Assert.AreEqual("11/14/2019 12:49:37 am", actual.StartTime?.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "startTime");
          Assert.AreEqual("Microsoft.VisualStudio.Services.ReleaseManagement", actual.LastChangedByUser, "LastChangedByUser");
 
          Assert.IsNotNull(actual.TriggerInfo, "TriggerInfo");
@@ -84,7 +84,7 @@ public void Build_Constructor_ById()
          Assert.AreEqual("Team Module-CI (1)", actual.DefinitionName, "DefinitionName");
          Assert.AreEqual("Donovan Brown", actual.RequestedByUser, "RequestedByUser");
          Assert.AreEqual("Donovan Brown", actual.RequestedForUser, "RequestedForUser");
-         Assert.AreEqual("9/23/2020 3:44:45 pm", actual.StartTime?.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "startTime");
+         Assert.AreEqual("9/23/2020 3:44:45 pm", actual.StartTime?.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "startTime");
          Assert.AreEqual("Microsoft.VisualStudio.Services.TFS", actual.LastChangedByUser, "LastChangedByUser");
 
          Assert.IsNotNull(actual.TriggerInfo, "TriggerInfo");

diff --git a/Tests/library/Provider/ExtensionTests.cs b/Tests/library/Provider/ExtensionTests.cs
@@ -27,7 +27,7 @@ public void Extension_Constructor()
          Assert.AreEqual("none", actual.InstallState.Flags, "InstallState.Flags");
          Assert.IsNotNull(actual.InstallState.InternalObject, "InstallState.InternalObject");
          Assert.IsTrue(actual.InstallState.ToString().StartsWith("Flags: none, Last Updated: "), "InstallState.ToString()");
-         Assert.AreEqual("8/10/2020 8:31:07 pm", actual.InstallState.LastUpdated.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "InstallState.LastUpdated");
+         Assert.AreEqual("8/10/2020 8:31:07 pm", actual.InstallState.LastUpdated.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "InstallState.LastUpdated");
       }
    }
 }
diff --git a/Tests/library/Provider/GitCommitRefTests.cs b/Tests/library/Provider/GitCommitRefTests.cs
@@ -30,7 +30,7 @@ public void GitCommitRefTests_Constructor()
          Assert.IsNotNull(target.Committer, "Committer");
          Assert.AreEqual("Donovan Brown", target.Committer.Name, "Committer.Name");
          Assert.AreEqual("Test@Test.com", target.Committer.Email, "Committer.Email");
-         Assert.AreEqual("8/8/2019 8:58:58 pm", target.Committer.Date.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "Committer.Date");
+         Assert.AreEqual("8/8/2019 8:58:58 pm", target.Committer.Date.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "Committer.Date");
       }
    }
 }
diff --git a/Tests/library/Provider/JobRequestTests.cs b/Tests/library/Provider/JobRequestTests.cs
@@ -27,10 +27,10 @@ public void JobRequest_Constructor_Completed()
          Assert.AreEqual("PTracker-CD", target.Pipeline, "Pipeline");
          Assert.AreEqual("------", target.DisplayMode, "DisplayMode");
          Assert.AreEqual(TimeSpan.Parse("00:10:58"), target.Duration, "Duration");
-         Assert.AreEqual("11/14/2019 12:56:12 am", target.QueueTime.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "QueueTime");
-         Assert.AreEqual("11/14/2019 12:56:15 am", target.StartTime?.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "StartTime");
-         Assert.AreEqual("11/14/2019 1:07:13 am", target.FinishTime?.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "FinishTime");
-         Assert.AreEqual("11/14/2019 12:56:12 am", target.AssignedTime?.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "AssignedTime");
+         Assert.AreEqual("11/14/2019 12:56:12 am", target.QueueTime.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "QueueTime");
+         Assert.AreEqual("11/14/2019 12:56:15 am", target.StartTime?.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "StartTime");
+         Assert.AreEqual("11/14/2019 1:07:13 am", target.FinishTime?.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "FinishTime");
+         Assert.AreEqual("11/14/2019 12:56:12 am", target.AssignedTime?.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "AssignedTime");
       }
 
       [TestMethod]

diff --git a/Tests/library/Provider/PackageVersionTests.cs b/Tests/library/Provider/PackageVersionTests.cs
@@ -26,7 +26,7 @@ public void PackageVersion_Constructor()
          Assert.AreEqual("@DonovanBrown", actual.Author, "author");
          Assert.AreEqual(expectedDesc, actual.Description, "Description");
          Assert.AreEqual("998abe34-23de-0000-9668b73891e2dada", actual.Id, "Id");
-         Assert.AreEqual("9/7/2018 1:33:39 pm", actual.PublishDate.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "PublishDate");
+         Assert.AreEqual("9/7/2018 1:33:39 pm", actual.PublishDate.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "PublishDate");
       }
    }
 }
diff --git a/Tests/library/Provider/ReleaseDefinitionTests.cs b/Tests/library/Provider/ReleaseDefinitionTests.cs
@@ -43,8 +43,8 @@ public void ReleaseDefinition_Constructor()
          Assert.AreEqual("", actual.ReleaseNameFormat, "ReleaseNameFormat");
          Assert.AreEqual("Chuck Reinhart", actual.CreatedByUser, "CreatedByUser");
          Assert.AreEqual("ReleaseDefinition", actual.ResourceType, "ResourceType");
-         Assert.AreEqual("12/11/2018 4:48:42 am", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
-         Assert.AreEqual("12/11/2018 4:48:42 am", actual.ModifiedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "ModifiedOn");
+         Assert.AreEqual("12/11/2018 4:48:42 am", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
+         Assert.AreEqual("12/11/2018 4:48:42 am", actual.ModifiedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "ModifiedOn");
          Assert.AreEqual("https://vsrm.dev.azure.com/fabrikam/00000000-0000-0000-0000-000000000000/_apis/Release/definitions/40", actual.Url, "Url");
       }
 
@@ -82,8 +82,8 @@ public void ReleaseDefinition_Constructor_NoEnvs()
          Assert.AreEqual(null, actual.Description, "Description");
          Assert.AreEqual("Donovan Brown", actual.CreatedByUser, "CreatedByUser");
          Assert.AreEqual("Release-$(rev:r)", actual.ReleaseNameFormat, "ReleaseNameFormat");
-         Assert.AreEqual("3/24/2019 4:46:08 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn");
-         Assert.AreEqual("9/16/2019 2:32:37 pm", actual.ModifiedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "ModifiedOn");
+         Assert.AreEqual("3/24/2019 4:46:08 pm", actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn");
+         Assert.AreEqual("9/16/2019 2:32:37 pm", actual.ModifiedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "ModifiedOn");
          Assert.AreEqual("https://vsrm.dev.azure.com/Test/00000000-0000-0000-0000-000000000000/_apis/Release/definitions/2", actual.Url, "Url");
       }
    }

diff --git a/Tests/library/Provider/ReleaseTests.cs b/Tests/library/Provider/ReleaseTests.cs
@@ -37,7 +37,7 @@ public void Release_Constructor()
 
          Assert.AreEqual("Test@Test.com", target.ModifiedBy.UniqueName, "ModifiedBy.UniqueName");
          Assert.AreEqual("Donovan Brown", target.CreatedBy.DisplayName, "CreatedBy.DisplayName");
-         Assert.AreEqual("11/14/2019 12:56:09 am", target.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn.ToString()");
+         Assert.AreEqual("11/14/2019 12:56:09 am", target.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn.ToString()");
 
          Assert.AreEqual("Donovan Brown", target.CreatedByUser, "CreatedByUser");
          Assert.AreEqual("Donovan Brown", target.ModifiedByUser, "ModifiedByUser");
@@ -66,7 +66,7 @@ public void Release_Constructor_Expand_Environments()
 
          Assert.AreEqual("test@test.com", target.ModifiedBy.UniqueName, "ModifiedBy.UniqueName");
          Assert.AreEqual("Donovan Brown", target.CreatedBy.DisplayName, "CreatedBy.DisplayName");
-         Assert.AreEqual("7/13/2019 3:49:31 pm", target.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "CreatedOn.ToString()");
+         Assert.AreEqual("7/13/2019 3:49:31 pm", target.CreatedOn.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "CreatedOn.ToString()");
       }
 
       [TestMethod]

diff --git a/Tests/library/Provider/UserEntitlementTests.cs b/Tests/library/Provider/UserEntitlementTests.cs
@@ -27,7 +27,7 @@ public void UserEntitlementTests_Constructor()
          Assert.AreEqual("Math lastName", target.DisplayName, "DisplayName");
          Assert.AreEqual("mlastName@test.com", target.UniqueName, "UniqueName");
          Assert.AreEqual("Early Adopter", target.AccessLevelName, "AccessLevelName");
-         Assert.AreEqual("9/9/2020 6:43:29 am", target.LastAccessedDate.ToString("M/d/yyyy h:mm:ss tt").ToLower(), "LastAccessedDate");
+         Assert.AreEqual("9/9/2020 6:43:29 am", target.LastAccessedDate.ToString("M/d/yyyy h:mm:ss tt", System.Globalization.CultureInfo.InvariantCulture).ToLower(), "LastAccessedDate");
       }
 
       [TestMethod]