fix tests that involve dates fail when OS culture has 24 hours format #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianSchuetze
requested changes
May 11, 2023
Move merge 'fix tests that involve dates fail when OS culture has 24 hours format' to next unpublished version
|
@SebastianSchuetze, can you please review last changes and merge? |
SebastianSchuetze
approved these changes
May 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Inside the vsteam-lib.Test project, tests that have Asserts based on date format (i.e.
actual.CreatedOn.ToString("M/d/yyyy h:mm:ss tt").) fails when ran in a Windows machine configured with 24h format, for example Spanish.See: https://stackoverflow.com/q/38976486/777551
Example of error:
The solution is to use an invariant culture so tests will be independent of the local configuration
PR Checklist