Sick Visionary.T.Pro

[jangernert]

No description provided.

[sisiplac]

Im am pretty sure that the intrinsics parameters are not interpreted correctly at the moment. Our ProjectiveTransformationZhang represents the Brown-Conrady model, whereas the parameters returned by GetIntrinsics seem to represent the inverse Brown-Conrady model. The topic will be clarified with Sick support team - probably we will need to change our code here.

[sisiplac]

Apart from the intrinsics topic I don't see any problems in the current implementation. Filters should be all deactivated using browser control of the camera, but that is possible. So here is my short todo list which has to be worked through before merge:

• Await feedback of Sick support team regarding intrinsics and change related code if needed.

[f00f]

using statements should be sorted alphabetically.

[f00f]

One of the force-pushes reverted changes made by me (use override instead of new, add Vendor to Visionary-T) and @sisiplac (look for InverseBrownConradyParams - it's gone).

I have created a new branch from my working copy, rebased to master: sick_pro_unforced. You may use that to recover a working implementation and redo your changes afterwards.

Please add your changes as new commits, so reviewers have a chance of keeping track.
No need to take care of the history, it's messed up already, and it will be squashed during the merge anyways into a single commit named "Add Sick Visionary-T Pro".

If the remote branch contains changes, rebase your changes onto that before pushing:

git push // fails because `origin` has other commits
git log  // note the hashes of your new commits
git fetch
git reset --hard origin/sick_pro   // undoes all your changes
git cherry-pick <your commit hash> // for all your new commits
git push

(I'll add this to our wiki, too)

[sisiplac]

From my side only the commit including the InverseBrownConrady changes was missing. I cherry-picked it from the new branch created by Hannes and had another (positive) live test with the camera.

[f00f]

Still has WIP in the title, and the wip-label. Therefore, I will not merge. But review is ok.

[jangernert]

@sisiplac and I have nothing left planned for now. So I'll remove the [WIP] and merge to master.