Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Custom Comet USWDS hooks #220

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Add Custom Comet USWDS hooks #220

merged 3 commits into from
Aug 5, 2024

Conversation

jbouder
Copy link
Collaborator

@jbouder jbouder commented Aug 5, 2024

There currently exists a few situations where direct importing of the USWDS modules is required with Comet-based apps. These include the modal for more advanced modal toggling and the header to support a more flexible header in the comet starter app. In order to simplify this process a new hooks section has been added to Comet to simplify current needs and support future growth as needed.

Description

  • Added new hooks section to comet-uswds
  • Added new useModal and useHeader hooks
  • Updated modal story to use new hook

Related Issue

N/A

Motivation and Context

  • More transparent and standardized approach

How Has This Been Tested?

  • Local Testing
  • Beta version tested in Comet Starter @metrostar/comet-uswds@2.4.0-beta.1

Screenshots (if appropriate):

N/A

@jbouder jbouder added the enhancement New feature or request label Aug 5, 2024
@jbouder jbouder changed the title Add USWDS hooks Add Custom Comet USWDS hooks Aug 5, 2024
Copy link
Collaborator

@kildre kildre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jbouder jbouder merged commit b39c34a into main Aug 5, 2024
5 checks passed
@jbouder jbouder deleted the modal-hooks branch August 5, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants