-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI scaling weirdly #115
Conversation
Thanks! I will look into this soon and provide feedback. Before that, may I ask how you want to be credited in the author list? "Kiisu-Master" or "Real Name (Kiisu-Master)"? |
Just Kiisu-Master, or Kiisu_Master which is my usual username which I couldn't use on github. Also I found that the scaling was set like that for high res screens ( #4 ). |
Maybe a user setting that changes |
There are a lot of things that must be addressed after this, but I think it's the right path forward for now. A For now, please try to address the following issues:
|
May I request splitting off the horizontal grabber in another PR, so I can merge that enhancement separately first? |
Why do you want to merge that separately? |
The ability to adjust the proportion between the inspector and display is separate from changing the stretch mode, both make sense on their own. |
c090b1e
to
8714b40
Compare
I talked about this approach and why I can't accept a PR solely implementing it in #342. A solution to this is really needed, and one of the highest priorities, but it requires a more thorough PR. |
Conflicts: project.godot
7a344a8
to
04e2ec1
Compare
YOLO |
I tried to fix the UI scaling in weird ways.
I am sure this is not the best way of fixing it, because I did some hacky things and didn't look into how it all actually works.
Sorry
Current problems with this fix:
Screenshot of what it looks like:
![image](https://private-user-images.githubusercontent.com/142301391/277828471-64179be6-af97-4fdd-9d25-acaf1bc9e731.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ1NTg2NzAsIm5iZiI6MTcyNDU1ODM3MCwicGF0aCI6Ii8xNDIzMDEzOTEvMjc3ODI4NDcxLTY0MTc5YmU2LWFmOTctNGZkZC05ZDI1LWFjYWYxYmM5ZTczMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyNVQwMzU5MzBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOTYzYWNiZTczNDBjMzMwMzc5Y2ZkZDQyZGQ0YjJiMGJhYjNjZGNmYWM4M2U3OTIwMmUwNjJmNDlhYTYxODEzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.T1M33hvKQpKR5FGjDsLmvB5Rnel2LZsfICNA8ngCMjg)