PPU Fix, Update mappers #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theypsilon
pushed a commit
to MiSTer-unstable-nightlies/NES_MiSTer
that referenced
this pull request
Apr 17, 2022
PPU Fix, Update mappers (changes from upstream commit 78f5b59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the PPU to appropriately show the pattern table address as the vram address during the unused cycle 340. This is important for the MMC3 mapper to use the real inverted M2 timings as seen in the decapped chip schematics from furrtek. This fixes Wario's Woods while using the real timings. Also in this PR several of the cheat signals given to the mappers could now be removed.