Only read referenced secret on template rendering #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an extra check to determine if the placeholder ocurrs in template content before actually reading the corresponding secret file. In terms of performance, this adds an extra string search, but removes possibly unneceassary file reading if the secret is not used in the template, though both of them should be negligible in most cases. Fixes Mic92#496.
DDoSolitary
changed the title
|
@mergify queue |
|
Thanks! |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f88661c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we can't use non-utf8 data in template, it's not a good idea to use
config.sops.secrets.<name>.formatto determine if a secret is actually utf8 text, as yaml secrets can have embedded binary data (#496) and "binary" secrets can actually contain utf8 text (#439).With this patch, we only read secret file when the corresponding placeholder actually occurs in template content. This way, we no longer need to try to exclude binary files from the replacement list, but rely on users to only reference text secret in templates.