Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build and release workflow #112

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Simplify build and release workflow #112

merged 5 commits into from
Aug 31, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Aug 8, 2022

Everything is tested to be working as intended in my fork.

@xmine64
Copy link
Member

xmine64 commented Aug 8, 2022

Nice work, thanks

@sitiom
Copy link
Contributor Author

sitiom commented Aug 28, 2022

@xmine64 bump

@xmine64
Copy link
Member

xmine64 commented Aug 31, 2022

Build failed but I merge anyway, will fix if it still fails later.

@xmine64 xmine64 merged commit 485d975 into MicaForEveryone:master Aug 31, 2022
@sitiom sitiom deleted the gh-actions branch August 31, 2022 09:06
@xmine64
Copy link
Member

xmine64 commented Aug 31, 2022

winget releaser doesn't work👀 matched installers are [] I guess we don't have access to artifacts from winget.yml workflow.

@sitiom
Copy link
Contributor Author

sitiom commented Aug 31, 2022

I think the installer regex is wrong, will fix.

@sitiom
Copy link
Contributor Author

sitiom commented Sep 28, 2022

@xmine64 I forgot an extra step: You should keep the fork regularly updated with Pull. Otherwise, it will eventually try to update the old workflows without the workflow scope, resulting in an error.

@xmine64
Copy link
Member

xmine64 commented Sep 28, 2022

Thanks, done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants