Better guarding of redis connection string

MichaCo · Nov 19, 2018 · 8c6b054 · 8c6b054
1 parent 6a605c5
commit 8c6b054
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/CacheManager.StackExchange.Redis/RedisConfiguration.cs b/src/CacheManager.StackExchange.Redis/RedisConfiguration.cs
@@ -193,6 +193,10 @@ public string ConnectionString
                 Database = _configurationOptions.DefaultDatabase ?? Database;
 
                 _connectionString = _configurationOptions.ToString();
+                if (string.IsNullOrWhiteSpace(_connectionString))
+                {
+                    throw new ArgumentException("Provided redis connection string seems to be invalid.");
+                }
             }
         }
 
@@ -309,4 +313,4 @@ public ServerEndPoint(string host, int port)
         /// <value>The host.</value>
         public string Host { get; set; }
     }
-}
+}
diff --git a/src/CacheManager.StackExchange.Redis/RedisConnectionManager.cs b/src/CacheManager.StackExchange.Redis/RedisConnectionManager.cs
@@ -23,6 +23,7 @@ public RedisConnectionManager(RedisConfiguration configuration, ILoggerFactory l
         {
             NotNull(configuration, nameof(configuration));
             NotNull(loggerFactory, nameof(loggerFactory));
+            NotNullOrWhiteSpace(configuration.ConnectionString, nameof(RedisConfiguration.ConnectionString));
 
             _configuration = configuration;
             _connectionString = configuration.ConnectionString;