Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release week 21 (DietPi v7.2 release) #494

Merged
merged 17 commits into from
May 29, 2021
Merged

Release week 21 (DietPi v7.2 release) #494

merged 17 commits into from
May 29, 2021

Conversation

MichaIng
Copy link
Owner

@MichaIng MichaIng commented May 25, 2021

Let's deploy this change directly.

@MichaIng MichaIng requested a review from fpetru May 25, 2021 11:26
@MichaIng MichaIng added the release Releases from dev to master branch label May 25, 2021
@MichaIng
Copy link
Owner Author

I deployed it to test URL. Looks great, but only one issue: The Firefox change has or can be misinterpreted:

By doing this, the browser will be installed automatically with the desktop of your choice. Earlier Firefox was installed with every desktop, and it only played a role when a desktop was installed, being also overridden by the manual browser selection.

By doing this, the browser will be installed only when a desktop is installed. It's like the webserver preference where a webserver will only be installed, when another software title requires one. So the only thing that has changed is that instead of having always Firefox installed, when a desktop got selected (or pulled as dependency for e.g. a VNC server), now you can choose whether Firefox, Chromium or no browser will be installed. It is not a "install this browser now" selection, like for file server, SSH server or logging system.

If this got misinterpreted, maybe we should rephrase the changelog and dietpi.txt entries to be clear about that? Because clarifying how the preference system works was something that was addressed together with that change, or should have been. Currently we have in CHANGELOG.txt:

  • DietPi-Software | A browser preference choice has been added. Before first boot via new dietpi.txt AUTO_SETUP_BROWSER_INDEX setting or with the new menu entry it can be now chosen whether and which browser to install automatically together with desktops. Previously Firefox was installed with every desktop. It only plays a role when a desktop is installed and is overridden by manual browser selections. With this change, Firefox has become an independent software option (see new software below).

and in dietpi.txt:

  • This defines the browser to install (only) when a desktop is installed.
  • It won't be installed if no desktop is installed and a manual browser selection will override it.

I think dietpi.txt is pretty clear, but the changelog entry is probably too complicated. Any suggestions to make this clearer?

For the desktop preference:

  • DietPi-Software | A desktop preference choice has been added. Before first boot via new dietpi.txt AUTO_SETUP_DESKTOP_INDEX setting or with the new menu entry it can be now chosen which desktop to install when another software selection requires one, especially remote desktop solutions. It works like the webserver preference, so it only play a role when a desktop is installed as dependency and is overridden by manual desktop selections.

@MichaIng MichaIng requested a review from StephanStS May 25, 2021 17:48
MichaIng and others added 4 commits May 27, 2021 23:27
Logo removed as it violates InfluxData's trademark guidelines: #485
Smaller visual enhancements and layout fixes have been appied.
+ Renamed "EmonPi" to "emonHub". The "emonPi" is the addon board hardware while our software option is the data collector backend which collects data from the emonPi, processes and sends it to frontends, like the emonCMS web interface, provided as public instance emoncms.org which is used by default. Making this clear by correct naming helps avoid confusing and allows us to implement emonCMS as local web interface as well. This was planned once but dropped as it lead to heavy regular disk writes. This however can be avoided by using Redis as RAM-based storage, which makes a local emonCMS attractive again to avoid relying on a public provider and regular public network connectivity.
+ Make clear that while we do not configure any other frontend or LCD screen by default (which is part of the all-in-one package with SBC + emonPi + LCD + case + OS image), everything can be setup manually, of course. OpenEnergyMonitor provides installer scripts for everything, if needed.
+ Add official docs, guides and source code links
@MichaIng MichaIng changed the title Release week 21 (DietPi release notes update) Release week 21 (DietPi v7.2 release) May 27, 2021
MichaIng and others added 3 commits May 27, 2021 23:38
*Total -- 453.93kb -> 389.22kb (14.26%)

/docs/assets/images/dietpi-banner_config.jpg -- 87.54kb -> 68.28kb (22%)
/docs/assets/images/dietpi-banner.jpg -- 151.55kb -> 122.36kb (19.26%)
/docs/assets/images/dietpi-ddns.jpg -- 39.35kb -> 33.58kb (14.66%)
/docs/assets/images/dietpi-pinebook-pro.jpg -- 14.91kb -> 12.81kb (14.11%)
/docs/assets/images/dietpi-nanopi_r1.jpg -- 51.26kb -> 47.63kb (7.08%)
/docs/assets/images/dietpi-nanopi_r4s.jpg -- 43.48kb -> 40.76kb (6.25%)
/docs/assets/images/dietpi-releaseinformation-7.2.svg -- 65.84kb -> 63.80kb (3.1%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@fpetru
Copy link
Collaborator

fpetru commented May 27, 2021

@MichaIng - good point on Firefox. Please update it as needed. Many thanks ;)

fpetru
fpetru previously approved these changes May 27, 2021
+ Change headings ID only where required, e.g. to add version strings and similar. In case of "DietPi Banner" it will be "dietpi-banner" automatically.
+ Extend image alt tags a little
And try to enhance wording for both preference options to hopefully better clarify how they work. Also links from software names to the related docs have been added.
@fpetru
Copy link
Collaborator

fpetru commented May 29, 2021

@StephanStS @MichaIng - Added the Node.js spec & small update of the browser selection feature (embedding @MichaIng comment, showing also the reason why this change was made). Kindly review / bring changes, so we can commit the PR. Thank you !

@fpetru fpetru self-requested a review May 29, 2021 15:26
@fpetru fpetru merged commit 96fd55d into master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Releases from dev to master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants