Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdGuard Home docs #515

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Add AdGuard Home docs #515

merged 4 commits into from
Jun 22, 2021

Conversation

Joulinar
Copy link
Collaborator

DietPi-Software | AdGuard Home - add new software title

DietPi-Software | AdGuard Home - add new software title
@Joulinar Joulinar added new content New documentation pages Next DietPi release Changes related to changes made for the upcoming DietPi release. labels Jun 13, 2021
@Joulinar Joulinar added this to the v7.3 milestone Jun 13, 2021
@Joulinar Joulinar self-assigned this Jun 13, 2021
@Joulinar Joulinar marked this pull request as draft June 13, 2021 13:08
@StephanStS StephanStS linked an issue Jun 13, 2021 that may be closed by this pull request
DietPi-Software | AdGuard Home - add new software title
@Joulinar Joulinar marked this pull request as ready for review June 14, 2021 09:41
small correction
@MichaIng
Copy link
Owner

I'll merge it, so we can prepare a dev => master PR.

@MichaIng MichaIng merged commit ce6126e into dev Jun 22, 2021
@MichaIng MichaIng deleted the AdGuardHome branch June 22, 2021 10:24
@Joulinar
Copy link
Collaborator Author

Joulinar commented Jun 22, 2021

I need to revert my statement a little bit. It seems there is an automatic update function. However it's not working with our implementation as the updater expect the executable on same directory as the config file

Jun 22 13:31:37 DietPi4 AdGuardHome[2973]: 2021/06/22 13:31:37 [info] Updating from v0.105.2 to v0.106.3.  URL:https://static.adguard.com/adguardhome/release/AdGuardHome_linux_arm64.tar.gz
Jun 22 13:31:37 DietPi4 AdGuardHome[2973]: 2021/06/22 13:31:37 [info] executable file /mnt/dietpi_userdata/adguardhome/AdGuardHome doesn't exist

🙄

@MichaIng
Copy link
Owner

MichaIng commented Jun 22, 2021

Oh, that is bad. I guess it expects it to be located in the working directory then, as this is all that we change. Strange that the related CLI option exists, when it expectedly breaks the updater 🤔. Probably something we should report to AdGuard guys, to derive the install dir form the location of the currently running executable, rather than assuming that it's located in the working directory.


Not sure how to deal with this for our release. Leave everything in /opt/adguardhome for now or in /mnt/dietpi_userdata/adguardhome or leave the updater broken (until hopefully it is able do function with a changed working dir) and refer to reinstall?

@Joulinar
Copy link
Collaborator Author

basically we would have 3 option

  1. keep everything in /opt/adguardhome
  2. move everything to /mnt/dietpi_userdata/adguardhome
  3. leave as is and hope behaviour will change in future

Currently AGH devs are working on v0.107 and it might be released short after our release. Means, we will have user reporting issues using the internal update function right after. For the time being, we could go with option 1, as this is similar to using AGH installation method and in parallel check with AGH developer if this intended or if they plan to split working dir from running executable. I mean you are right, using -w option is a little but useless at the moment.

@MichaIng
Copy link
Owner

FYI: AdguardTeam/AdGuardHome#3286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new content New documentation pages Next DietPi release Changes related to changes made for the upcoming DietPi release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DietPi-Software | AdGuard Home - add new software title
2 participants