Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable standard header also in the documentation portal #971

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

fpetru
Copy link
Collaborator

@fpetru fpetru commented Feb 1, 2024

Linked to: #970
It is a first try, repurposing the header, and use the standard menu.

@fpetru fpetru added the meta Topics that do not deal with the actual docs content, e.g. GitHub actions label Feb 1, 2024
@fpetru fpetru self-assigned this Feb 1, 2024
@fpetru fpetru marked this pull request as draft February 1, 2024 16:26
@fpetru fpetru removed the meta Topics that do not deal with the actual docs content, e.g. GitHub actions label Feb 1, 2024
@fpetru fpetru requested a review from MichaIng February 4, 2024 17:00
@fpetru fpetru marked this pull request as ready for review February 4, 2024 17:00
@fpetru
Copy link
Collaborator Author

fpetru commented Feb 4, 2024

Hi @MichaIng and @StephanStS, would this kind of idea work? We could work on CSS to change maybe the fonts. Please share your feedback, considering this as a starting idea.

@StephanStS
Copy link
Collaborator

StephanStS commented Feb 4, 2024

Very nice.

I do not dare to ask for the DietPi logo on the left side ...
grafik

-> https://github.com/MichaIng/DietPi-Website/blob/master/images/dietpi-logo_240x80.png

overrides/main.html Outdated Show resolved Hide resolved
@MichaIng
Copy link
Owner

MichaIng commented Feb 4, 2024

Would be actually great to align the style with the main website. Here is the CSS: https://github.com/MichaIng/DietPi-Website/blob/master/css/style.css#L103-L117

The DOCS link could have the "active" class or the border color given inline, so it is always green, indicating where we are, like on the contribution page: https://dietpi.com/contribute.html

@fpetru
Copy link
Collaborator Author

fpetru commented Feb 4, 2024

thanks @MichaIng and @StephanStS - great inputs. I will review and update the PR, making a new proposal for review.

Copy link
Collaborator

@StephanStS StephanStS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpetru: Let's change to HOME, DOCS and finish the PR.

overrides/main.html Outdated Show resolved Hide resolved
@MichaIng MichaIng force-pushed the dev-petru-enable-menu branch 2 times, most recently from c3b78d1 to 1cada6f Compare March 7, 2024 18:39
@MichaIng MichaIng added this to the v9.2 milestone Mar 7, 2024
@MichaIng MichaIng added the enhancement Content or wording enhancements label Mar 7, 2024
@MichaIng
Copy link
Owner

MichaIng commented Mar 7, 2024

Okay, the navigation bar should now work and behave exactly like the one on our home page:
image

For now, on mobile phones, the buttons like be shown in multiple lines:
image

I think it is okay like that, as long as no one finds time to implement a hamburger menu. And a hamburger menu might contradict the idea to make site navigation more prominent + may look weird as there is already one on the left side for the MkDocs navigation.

We could tweak it a way that the buttons are made smaller on screen below a certain width, or we could even hide some buttons there.

Btw, the reason to have DOCS there as well, was that it gives you an impression where you currently are among our sites:
image

But this worsens the situation on mobile phones, hence I think it is not worth it.

@fpetru fpetru merged commit 79f502e into dev Mar 7, 2024
3 checks passed
@fpetru fpetru deleted the dev-petru-enable-menu branch March 7, 2024 19:40
@MichaIng MichaIng linked an issue Mar 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Content or wording enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace header/banner with top level navigation
3 participants