Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DietPi-Globals | Renamed G_USER_INPUTS to G_INTERACTIVE #3041

Merged
merged 4 commits into from
Aug 7, 2019
Merged

DietPi-Globals | Renamed G_USER_INPUTS to G_INTERACTIVE #3041

merged 4 commits into from
Aug 7, 2019

Conversation

alpha-tango-kilo
Copy link
Contributor

Status: Ready
Needs checking that it actually works in the real world (specifically the backwards compatibility with scripts), but exporting a value to G_USER_INPUTS is picked up by dietpi-globals and G_INTERACTIVE is then given the value

Reference: #3033 (comment)

Commit list/description:

  1. I used skill find to replace all instances of G_USER_INPUTS with G_INTERACTIVE
  2. Ignore this commit, aliases don't work in scripts
  3. I fixed it, making the variable name change backwards compatible

The point of the PR is basically to make the global variable's name more self-explanatory, while being backwards compatible for the sake of any existing users' scripts

@MichaIng
Copy link
Owner

MichaIng commented Aug 7, 2019

@AtkLordOverAll
Many thanks for this, looks good.
I will move the G_USER_INPUTS handling into the G_INTERACTIVE existence check, so the latter has priority and if it exists, a tiny step less is done.

+ DietPi-Globals | Apply G_USER_INPUTS backwards compatibility only if G_INTERACTIVE is not set, to make the latter take priority
@MichaIng MichaIng merged commit aa5002d into MichaIng:dev Aug 7, 2019
@alpha-tango-kilo alpha-tango-kilo deleted the g_interactive branch August 7, 2019 15:18
@MichaIng
Copy link
Owner

MichaIng commented Aug 8, 2019

Changelog: 03b883c

@MichaIng MichaIng mentioned this pull request Sep 16, 2019
@MichaIng MichaIng mentioned this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants