convert signal_values into dict so in c it will become a set

--HG-- branch : win32-cleanup2
MichaelBlume · May 7, 2012 · fbe94f7 · fbe94f7
1 parent 359883c
commit fbe94f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/pypy/module/signal/interp_signal.py b/pypy/module/signal/interp_signal.py
@@ -25,6 +25,9 @@ def setup():
 SIG_IGN = cpy_signal.SIG_IGN
 signal_names = list(setup())
 signal_values = [globals()[key] for key in signal_names]
+signal_values = {}
+for key in signal_names:
+    signal_values[globals()[key]] = None
 
 includes = ['stdlib.h', 'src/signals.h']
 if sys.platform != 'win32':
@@ -244,7 +247,7 @@ def pause(space):
     return space.w_None
 
 def check_signum(space, signum):
-    for sig in signal_values:
+    for sig in signal_values.keys():
         if signum == sig:
             return
     raise OperationError(space.w_ValueError,

diff --git a/pypy/module/signal/test/test_signal.py b/pypy/module/signal/test/test_signal.py
@@ -38,8 +38,6 @@ def myhandler(signum, frame):
 class AppTestSignal:
 
     def setup_class(cls):
-        if not hasattr(os, 'kill') or not hasattr(os, 'getpid'):
-            py.test.skip("requires os.kill() and os.getpid()")
         space = gettestobjspace(usemodules=['signal'])
         cls.space = space
         cls.w_signal = space.appexec([], "(): import signal; return signal")