Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolvers): resolve #1142 name issue and add relevant tests #1309

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

AvKat
Copy link
Contributor

@AvKat AvKat commented Jul 15, 2022

This PR fixes the issue mentioned here with tests as mentioned here.
The tests successfully fail when the startsWith is replaced back with includes.

(Edit: The second 'here' is supposed to link to the last comment of the mentioned issue but it's not scrolling.)

@MichalLytek MichalLytek self-requested a review February 10, 2023 14:17
@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Bugfix 🐛 🔨 PR that fixes a known bug labels Feb 10, 2023
@MichalLytek MichalLytek added this to the 2.0 release milestone Feb 10, 2023
@AvKat
Copy link
Contributor Author

AvKat commented Feb 11, 2023

I'm sorry I got some emails today from github regarding this repo but I don't understand. Am I supposed to do something?

@MichalLytek
Copy link
Owner

Nope, i just set myself as a reviewer to not forget about this PR, don't worry 😉

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51ff280) 95.50% compared to head (8074c56) 95.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1309   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         113      113           
  Lines        1848     1848           
  Branches      364      364           
=======================================
  Hits         1765     1765           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichalLytek MichalLytek merged commit e7b4e09 into MichalLytek:master Jan 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 🔨 PR that fixes a known bug Community 👨‍👧 Something initiated by a community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants