Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: removed postinstall script #1363

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

carlocorradini
Copy link
Contributor

Fix #1339

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 96.05% // Head: 96.85% // Increases project coverage by +0.79% 🎉

Coverage data is based on head (7ea72c1) compared to base (3137ab5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
+ Coverage   96.05%   96.85%   +0.79%     
==========================================
  Files          79       78       -1     
  Lines        1700     1686      -14     
  Branches      356      336      -20     
==========================================
  Hits         1633     1633              
+ Misses         66       52      -14     
  Partials        1        1              

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MichalLytek
Copy link
Owner

Can you also add npm fund entry?

@carlocorradini
Copy link
Contributor Author

Already available at line 109 :)

@MichalLytek
Copy link
Owner

Ah so I did it long time ago 😅

@MichalLytek MichalLytek added Community 👨‍👧 Something initiated by a community Internal 🏠 All the things related to internal parts labels Oct 16, 2022
@MichalLytek MichalLytek self-requested a review October 16, 2022 08:46
@MichalLytek
Copy link
Owner

@carlocorradini Can we add also a link to github sponsors?

@carlocorradini
Copy link
Contributor Author

Where?

@carlocorradini
Copy link
Contributor Author

Where?

I'll modify funding as an array instead of object

@carlocorradini
Copy link
Contributor Author

@MichalLytek Done! 🥳

@MichalLytek MichalLytek merged commit 035145b into MichalLytek:master Nov 2, 2022
@carlocorradini carlocorradini deleted the funding branch November 2, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Internal 🏠 All the things related to internal parts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-install script causes failures
2 participants