Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate subscriptions engine to graphql-yoga #1578

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Nov 22, 2023

  • use @graphql-yoga instead of graphql-subscriptions as the subscriptions engine
  • require providing PubSub implementation into buildSchema option when using @Subscription
  • remove @PubSub in favor of directly importing created PubSub implementation
  • remove Publisher and PubSubEngine types
  • add support for dynamic topic id function in @Subscription decorator option

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Nov 22, 2023
@MichalLytek MichalLytek added this to the 2.0 release milestone Nov 22, 2023
@MichalLytek MichalLytek self-assigned this Nov 22, 2023
@MichalLytek MichalLytek added this to In review in Board via automation Nov 22, 2023
@carlocorradini
Copy link
Contributor

@MichalLytek Awesome.

What is missing?

@MichalLytek
Copy link
Owner Author

@carlocorradini Fixing pipeline issues, upgrading redis subscriptions example.

@carlocorradini
Copy link
Contributor

Can I help somehow? ☺️

@carlocorradini
Copy link
Contributor

@MichalLytek See PR #1590 🤗🥳

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ad04ab) 95.52% compared to head (f5aa0d0) 95.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1578      +/-   ##
==========================================
- Coverage   95.52%   95.50%   -0.02%     
==========================================
  Files         113      113              
  Lines        1854     1848       -6     
  Branches      367      364       -3     
==========================================
- Hits         1771     1765       -6     
  Misses         83       83              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichalLytek MichalLytek marked this pull request as ready for review January 3, 2024 09:09
@MichalLytek MichalLytek changed the title Migrate subscriptions engine graphql-yoga Migrate subscriptions engine to graphql-yoga Jan 3, 2024
@MichalLytek MichalLytek merged commit a088c25 into master Jan 3, 2024
7 of 8 checks passed
Board automation moved this from In review to Done Jan 3, 2024
@MichalLytek MichalLytek deleted the subscriptions-upgrade branch January 3, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
Board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants