Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(ci): workflows that depends on another workflow #1597

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

carlocorradini
Copy link
Contributor

  • Fixed workflows that depends on another workflow
  • actions/checkout always clone the corresponding ref to avoid clashes with master
  • Cancel parallel workflows (concurrency) if the corresponding workflow must be run uniquely (e.g. release and license)

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e28a028) 95.50% compared to head (a9e6ed2) 95.50%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         113      113           
  Lines        1848     1848           
  Branches      364      364           
=======================================
  Hits         1765     1765           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlocorradini
Copy link
Contributor Author

Lol CodeQL fails.
I'll update all workflows following the recommendations from https://github.blog/2023-08-09-four-tips-to-keep-your-github-actions-workflows-secure/

@carlocorradini
Copy link
Contributor Author

@MichalLytek Done 🛡

@MichalLytek MichalLytek added Chore 🔨 Work not related with main project goal Bugfix 🐛 🔨 PR that fixes a known bug labels Jan 6, 2024
Copy link
Owner

@MichalLytek MichalLytek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see 👀

@MichalLytek MichalLytek merged commit 38e80c0 into MichalLytek:master Jan 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 🔨 PR that fixes a known bug Chore 🔨 Work not related with main project goal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants