Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphQL packages peer dependencies #239

Merged
merged 4 commits into from Jan 24, 2019
Merged

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Jan 23, 2019

This PR makes graphql and @types/graphql a peer dependencies. This will allow for better interop with other GraphQL ecosystem libraries without version conflict issues.

It also introduces the strict version check in runtime using node-semver to ensure that users update the peer dependencies on TypeGraphQL update - this trick will limit all weird runtime errors that might occur when TypeGraphQL uses some new graphql-js features.

@MichalLytek MichalLytek added the Enhancement 🆕 New feature or request label Jan 23, 2019
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Jan 23, 2019
@MichalLytek MichalLytek self-assigned this Jan 23, 2019
@MichalLytek MichalLytek added this to In review in Board via automation Jan 23, 2019
@codecov
Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #239 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   95.49%   95.57%   +0.08%     
==========================================
  Files          65       67       +2     
  Lines        1043     1063      +20     
  Branches      186      187       +1     
==========================================
+ Hits          996     1016      +20     
  Misses         46       46              
  Partials        1        1
Impacted Files Coverage Δ
src/utils/graphql-version.ts 100% <100%> (ø)
src/errors/index.ts 100% <100%> (ø) ⬆️
src/errors/UnmetGraphQLPeerDependencyError.ts 100% <100%> (ø)
src/schema/schema-generator.ts 97.12% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d4858...7d575ec. Read the comment docs.

@MichalLytek MichalLytek changed the title Make GraphQL packages a peer dependencies Make GraphQL packages peer dependencies Jan 24, 2019
@MichalLytek MichalLytek merged commit 6fc9138 into master Jan 24, 2019
Board automation moved this from In review to Done Jan 24, 2019
@MichalLytek MichalLytek deleted the graphql-peerDeps branch January 24, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
Board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant