-
-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Next.js browser shim and update headers/format #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #669 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 113 113
Lines 1847 1847
Branches 364 362 -2
=======================================
Hits 1764 1764
Misses 83 83 ☔ View full report in Codecov by Sentry. |
MichalLytek
requested changes
Jul 13, 2020
a190360
to
f50d1d0
Compare
6e1c81e
to
c8d2e2d
Compare
[Updated layout since the PR before was not consistent] Since Next.js is quite popular and it took me some time to figure this out, this might be helpful for others
MichalLytek
approved these changes
May 3, 2024
I've rebased this branch and applied all the resolutions from the discussion. It's now ready to merge 😉 @desmap Thanks for your contribution! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Updated layout since the PR before was not consistent] Since Next.js is quite popular and it took me some time to figure this out, this might be helpful for others