Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Next.js browser shim and update headers/format #669

Merged
merged 1 commit into from
May 3, 2024

Conversation

desmap
Copy link
Contributor

@desmap desmap commented Jul 8, 2020

[Updated layout since the PR before was not consistent] Since Next.js is quite popular and it took me some time to figure this out, this might be helpful for others

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (be33fd4) to head (005fd6a).
Report is 22 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #669   +/-   ##
=======================================
  Coverage   95.50%   95.50%           
=======================================
  Files         113      113           
  Lines        1847     1847           
  Branches      364      362    -2     
=======================================
  Hits         1764     1764           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichalLytek MichalLytek self-requested a review July 13, 2020 15:43
docs/browser-usage.md Outdated Show resolved Hide resolved
docs/browser-usage.md Show resolved Hide resolved
docs/browser-usage.md Show resolved Hide resolved
docs/browser-usage.md Outdated Show resolved Hide resolved
[Updated layout since the PR before was not consistent] Since Next.js is quite popular and it took me some time to figure this out, this might be helpful for others
@MichalLytek
Copy link
Owner

I've rebased this branch and applied all the resolutions from the discussion. It's now ready to merge 😉

@desmap Thanks for your contribution! 🙌

@MichalLytek MichalLytek merged commit 45e33de into MichalLytek:master May 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community 👨‍👧 Something initiated by a community Documentation 📖 Issues about docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants