Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move react-test-renderer to peer dependency #57

Merged

Conversation

ShMcK
Copy link
Contributor

@ShMcK ShMcK commented Jun 26, 2018

Closes #56.

Fixes

  • Reduces the project size by moving "react-test-renderer" into a peerDependency.
  • Also ensures that "react-test-renderer" can match the version of "react" used in the project.

Future Suggestions

I tried to move PropTypes as a dev dependency, but it seems it is currently used within React-Automata. Something that might be considered as a change, but not a big deal.

@ShMcK ShMcK force-pushed the fix/refactor-dependencies branch from 8c02c61 to 01f0d36 Compare June 26, 2018 01:46
@MicheleBertoli
Copy link
Owner

Thank you very much, @ShMcK.

@MicheleBertoli MicheleBertoli merged commit 2bb52cc into MicheleBertoli:master Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants