Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

add new beanValidation booster #357

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Conversation

ajm01
Copy link
Member

@ajm01 ajm01 commented Aug 21, 2019

in getting boost to work with the systemTest testcontainer framework, the test app required the beanValidation liberty feature to be present in server.xml. Since we did not already have a booster to do provide this entry, I added it here.

Copy link
Contributor

@scottkurz scottkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with those two comments...

  1. Should we add bval 1.1 for EE 7 too?
  2. Could we add a real simple annotation to one of the jax-rs integration tests and get this bit of coverage for bval too?

<dependency>
<groupId>boost.boosters</groupId>
<artifactId>boost-ee8-apis-bom</artifactId>
<version>0.1-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We said we were going to move away from this right? I think that's still in the backlog but you might as well start.

<modelVersion>4.0.0</modelVersion>

<groupId>boost.boosters</groupId>
<artifactId>beanValidation</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'beanValidation' => 'bean-validation' or even just 'validation' (as with the API). Kinda like 'bean-validation'

@ajm01 ajm01 merged commit 8e34d0e into MicroShed:master Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants