boost project versioning cleanup #366
Conversation
| <scope>import</scope> | ||
| <type>pom</type> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
Didn't we mean to import the runtimes BOM?
There was a problem hiding this comment.
missed this one, now importing the runtime bom
| <scope>import</scope> | ||
| <type>pom</type> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>boost.boosters</groupId> | ||
| <artifactId>ee8-bom</artifactId> | ||
| <version>0.1.3-SNAPSHOT</version> | ||
| <version>1.0-M1-SNAPSHOT</version> |
There was a problem hiding this comment.
You didn't cause this issue.. but MP 1.4 correlates to EE 7, not 8
There was a problem hiding this comment.
What does it say about our IT coverage that we don't catch this? Is this actually not taking precedence and so is just harmless noise? Or do we not really care if we get EE 8 level features since they are back compatible with EE 7 test apps?
Those are kind of open-ended, so let me ask a simpler question: do we every use the mp14-bom in any IT? Might we at least add one IT to do that here?
There was a problem hiding this comment.
switched to ee7 - and switched the mpHealth IT to use the mp14 bom
| @@ -32,11 +32,21 @@ | |||
|
|
|||
| <dependencyManagement> | |||
| <dependencies> | |||
| <!-- | |||
There was a problem hiding this comment.
Why did you comment this out as opposed to just deleting it? Had we talked about being unsure here?
There was a problem hiding this comment.
deleted commented out stanzas
| <type>pom</type> | ||
| <scope>import</scope> | ||
| </dependency> | ||
| <!-- | ||
| <dependency> |
There was a problem hiding this comment.
You can just delete this.
| </dependency> | ||
| --> | ||
| <dependency> |
| <groupId>org.eclipse.microprofile</groupId> | ||
| <artifactId>microprofile</artifactId> | ||
| <version>2.0</version> | ||
| <type>pom</type> |
| @@ -11,7 +11,7 @@ | |||
| <groupId>boost.boosters</groupId> | |||
There was a problem hiding this comment.
We were going to make a new gid for the BOMs right?
There was a problem hiding this comment.
changed boms groupids to boost.boms
ajm01
force-pushed
the
bom-versioning-cleanup-339
branch
2 times, most recently
from
5cd71d5
to
3d620fe
Compare
ajm01
force-pushed
the
bom-versioning-cleanup-339
branch
from
3d620fe
to
009c45b
Compare
addressed items in task #339