Skip to content

Commit

Permalink
updated target LightGBM version in warnings (#1668)
Browse files Browse the repository at this point in the history
  • Loading branch information
StrikerRUS authored and henry0312 committed Sep 15, 2018
1 parent e1b5901 commit c1320da
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion python-package/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ For **macOS** users, **gcc** with **OpenMP** support must be installed first. Re

For **macOS** users, latest versions of LightGBM are built with **gcc-8** and cannot be launched on systems with **gcc-7** and earlier. You should update your **gcc** compiler if you don't want to build from sources or install LightGBM 2.1.1 which is the last version built with **gcc-7**.

For **macOS** users, starting from version 2.1.4, the library file in distribution wheels will be built by the **Apple Clang** compiler. This means that you won't need to install the **gcc** compiler anymore. Instead of that you'll need to install the **OpenMP** library, which is required for running LightGBM on the system with the **Apple Clang** compiler. You can install the **OpenMP** library by the following command: ``brew install libomp``.
For **macOS** users, starting from version 2.2.1, the library file in distribution wheels will be built by the **Apple Clang** compiler. This means that you won't need to install the **gcc** compiler anymore. Instead of that you'll need to install the **OpenMP** library, which is required for running LightGBM on the system with the **Apple Clang** compiler. You can install the **OpenMP** library by the following command: ``brew install libomp``.

Install `wheel <http://pythonwheels.com>`_ via ``pip install wheel`` first. After that download the wheel file and install from it:

Expand Down
2 changes: 1 addition & 1 deletion python-package/lightgbm/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
'plot_importance', 'plot_metric', 'plot_tree', 'create_tree_digraph']

if system() == 'Darwin':
warnings.warn("Starting from version 2.1.4, the library file in distribution wheels for macOS "
warnings.warn("Starting from version 2.2.1, the library file in distribution wheels for macOS "
"will be built by the Apple Clang compiler.\n"
"This means that in case of installing LightGBM from PyPI via the ``pip install lightgbm`` command, "
"you won't need to install the gcc compiler anymore.\n"
Expand Down
6 changes: 3 additions & 3 deletions python-package/lightgbm/plotting.py
Original file line number Diff line number Diff line change
Expand Up @@ -348,13 +348,13 @@ def create_tree_digraph(booster, tree_index=0, show_info=None, precision=None,
'old_node_attr', 'old_edge_attr', 'old_body']:
param = locals().get(param_name)
if param is not None:
warnings.warn('{0} parameter is deprecated and will be removed in 2.3 version.\n'
warnings.warn('{0} parameter is deprecated and will be removed in 2.4 version.\n'
'Please use **kwargs to pass {1} parameter.'.format(param_name, param_name[4:]),
LGBMDeprecationWarning)
if param_name[4:] not in kwargs:
kwargs[param_name[4:]] = param
if locals().get('strict'):
warnings.warn('old_strict parameter is deprecated and will be removed in 2.3 version.\n'
warnings.warn('old_strict parameter is deprecated and will be removed in 2.4 version.\n'
'Please use **kwargs to pass strict parameter.',
LGBMDeprecationWarning)
if 'strict' not in kwargs:
Expand Down Expand Up @@ -424,7 +424,7 @@ def plot_tree(booster, ax=None, tree_index=0, figsize=None,
for param_name in ['old_graph_attr', 'old_node_attr', 'old_edge_attr']:
param = locals().get(param_name)
if param is not None:
warnings.warn('{0} parameter is deprecated and will be removed in 2.3 version.\n'
warnings.warn('{0} parameter is deprecated and will be removed in 2.4 version.\n'
'Please use **kwargs to pass {1} parameter.'.format(param_name, param_name[4:]),
LGBMDeprecationWarning)
if param_name[4:] not in kwargs:
Expand Down
2 changes: 1 addition & 1 deletion src/objective/binary_objective.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class BinaryLogloss: public ObjectiveFunction {
weights_ = metadata.weights();
data_size_t cnt_positive = 0;
data_size_t cnt_negative = 0;
// REMOVEME: remove the warning after 2.3 version release
// REMOVEME: remove the warning after 2.4 version release
Log::Warning("Starting from the 2.1.2 version, default value for "
"the \"boost_from_average\" parameter in \"binary\" objective is true.\n"
"This may cause significantly different results comparing to the previous versions of LightGBM.\n"
Expand Down

0 comments on commit c1320da

Please sign in to comment.