-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instruction for R-package installation with precompiled dll/lib #598
Conversation
R-package/README.md
Outdated
@@ -9,7 +9,7 @@ You need to install git and [cmake](https://cmake.org/) first. | |||
|
|||
The default compiler is Visual Studio (or [MS Build](https://www.visualstudio.com/downloads/#build-tools-for-visual-studio-2017)) in Windows. You also can use Rtools (default) or [MinGW64](https://sourceforge.net/projects/mingw-w64/files/Toolchains%20targetting%20Win64/Personal%20Builds/mingw-builds/) (x86_64-posix-seh) to compile by setting `use_mingw` to `TRUE` in `R-package/src/install.libs.R`. | |||
|
|||
It is recommended to use *Visual Studio* for its better multi-threading efficency in Windows for many core systems. For simple systems (like laptops or small desktops), MinGW64 is recommended. | |||
It is recommended to use *Visual Studio* for its better multi-threading efficency in Windows for many core systems. For simple systems (like laptops or small desktops), MinGW64 is recommended. By default, it will attempt to build the package using Visual Studio. For MinGW users who wants to install online, please check the end of this document for installation using a helper package ([Laurae2/lgbdl](https://github.com/Laurae2/lgbdl/)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, it will attempt to build the package using Visual Studio.
seems is duplicate to The default compiler is Visual Studio
at line 10 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@Laurae2 Another problem is: The Rtools seems is still needed when build from visual studio. I try to build without Rtools, and it fails. |
@guolinke Unfortunately, can't install any R package without Rtools in Windows when it has a |
Rtools is 99.99% mandatory to live with Windows and R packages, so it should not be much a problem (especially for high performance purposes without precompiled packages). I know there might be issues on heavily locked down machines about installing and using Rtools: r-lib/devtools#200 (comment) |
R-package/README.md
Outdated
|
||
It is recommended to use *Visual Studio* for its better multi-threading efficency in Windows for many core systems. For simple systems (like laptops or small desktops), MinGW64 is recommended. By default, it will attempt to build the package using Visual Studio. For MinGW users who wants to install online, please check the end of this document for installation using a helper package ([Laurae2/lgbdl](https://github.com/Laurae2/lgbdl/)). | ||
It is recommended to use *Visual Studio* for its better multi-threading efficency in Windows for many core systems. For simple systems (like laptops or small desktops), MinGW64 is recommended for maximum performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, In my i7-6700, VS is still faster than MinGW. And from your result on i7-4600u, the gap seems is also small (about 105%) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the wording of the sentence. User by default should choose VS when they don't know, but fall back to MinGW if they have a special need on a slow dual core system (or worse).
* readme Helper package for R-package installation * Fix code indentation bug * Add warning about default compiler in Windows * Avoid repeat * Add Rtools requirement * Wording to promote VS as default choice for user
Some instructions for R-package installation with precompiled dll/lib.