HTK Utility updates for sharing services #496
Conversation
Added ExternalResourcesHelper to decompress External.zip at the root of project for easy implementation of sharing services.
…xed path. Good for people who like to move their third party assets into other folders like myself.
Added instructions for setup via HoloToolkit->Config->Apply HoloLens Project Settings
added missing capability
…et package compliance.
Included environment setup and requirements for project.
removed nit extra line
| @@ -0,0 +1 @@ | |||
| This folder is for the Externals.zip that should alway be up to date. | |||
There was a problem hiding this comment.
Why are we doing this? Just because we are unable to add the externals folder into the asset package?
One of the main reasons for making it external was they are binary files that don't compile under Assets.
Adding a zip file with the same stuff does not help that cause.
I think we can come up with a better solution than a zip file under Assets.
Just for solving the problem of mismatching SharingServer.exe binaries problem, we could always add a check in code in the Launch Sharing Service option to check version numbers. I think that would better than the zip.
What do you think?
There was a problem hiding this comment.
Perhaps print a message, please download latest sharing binaries or something akin.
There was a problem hiding this comment.
This was just a placeholder file I meant to delete.
But the purpose of the zip file is so that users have everything they need when they import the asset package the first time. The external binaries are in the zip file and are only unpacked when users opt to use the sharing services in the HoloToolkit/Configure/Apply Project Settings menu.
The inclusion of this zip file shouldn't affect compile time, nor make it into a build.
There was a problem hiding this comment.
But it does mean there is another copy of this uncompilable code in the repo now right? I guess that's what I'm not sure if the best option. So when someone updates the External folder they also now need to update the zip file.
There was a problem hiding this comment.
Everything would compile fine, lol. This PR would create a duplicate of the External resources but in a zipped format (I would like to discuss exactly how we want to handle that). Ideally this Externals folder should only live in the HoloToolkit and not this repo, with this repo only having the bundled external assets that could, in theory, get updated automatically (pretty much what #279 talks about). Currently it would have to be done by hand, but to be honest, the main HoloToolkit doesn't really change all that often.
I'm thinking about this in a couple of ways:
- This project is a simple framework for learning & sharing with the community.
- This project is for staging and deploying an asset package that people will download, either from here or the Unity Asset Store, and should contain all the resources needed.
- For advanced developers to download and tailor this project by exporting an asset package that fits their needs.
The main goal of the bundled external resources is to ensure when people import the asset package they have everything they need to get started all in one place. Currently you'd have to go and find the sharing services, download them, then make sure they're in the correct place yourself.
Currently if someone was to create a new project and import the current asset package, and try to use any of the menu items related to the sharing service they will get errors:
The second message talking about manually coping some .exe is rather vague. It doesn't even give you a clue where to obtain it, considering that external folder doesn't exist if you've only downloaded just the asset package and not the whole HTK project.
…plus localuser id. Updated PrefabSpawnManager to initialize spawnablePrefabs w/null to prevent warning during build. removed placeholder readme meta file.
Wrapped WSA code for Anchors for easy use in editor.
…t. Replaced with !KeepRoomAlive.
Added better support for knowing if we're connected when Start is called. (maybe our gameobject wasn't initialized before we got a connection event)
…first in the session.
removed extra lines
|
I'm going to resubmit this and break apart the sharing service updates and the update to the utilities stuff. The new sharing service PR will only contain fixes, |
|
@StephenHodgson, |
StephenHodgson
changed the title
TL;DR-Cleans up the project for smoother deployment as a fully functional asset package w/sharing services
Resolves #490
Resolves #487
Resolves #374
HoloToolkit -> Configure -> Update External ResourcesThe main goal of the bundled external resources is to ensure when people import the asset package they have everything they need to get started all in one place. Currently you'd have to go and find the sharing services, download them, then make sure they're in the correct place yourself.
My thoughts that influenced this change:
Currently if someone was to create a new project and import the current asset package, and try to use any of the menu items related to the sharing service they will get errors:
The second message talking about manually coping some .exe is rather vague. It doesn't even give you a clue where to obtain it, considering that external folder doesn't exist if you've only downloaded just the asset package and not the whole HTK project.