Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lag on the quickreturnheader #1050

Closed
karmaecrivain94 opened this issue Mar 25, 2017 · 5 comments
Closed

Lag on the quickreturnheader #1050

karmaecrivain94 opened this issue Mar 25, 2017 · 5 comments

Comments

@karmaecrivain94
Copy link
Contributor

There's a noticeable lag on the QuickReturnHeader: The movement of the header and the scrolling isn't very tightly synchronized, as, especially when scrolling up, the header seems to lag behind. There's also often a pixel wide gap at the top of the header.

It may seem superficial, but details like this have a big impact on how polished an app feels. Could someone reading this from msft ask how the Groove Music team achieved the same effect?

@deltakosh
Copy link
Contributor

I'm not sure to see this lag.. Can you capture a video to be sure we are talking about the same thing?

@JohnnyWestlake
Copy link
Contributor

If this only when using the scrollbar on desktop, or also with touch?

@lukasf
Copy link
Contributor

lukasf commented May 3, 2017

I also noticed that the control lags quite a lot in quick return mode. To me it happens when scrolling with touch pad gestures. Much like the OP my first thought was, I would not use this in an app. It looks very unprofessional with this kind of lag.

The problem is that in quick return mode, the header position is updated manually on each scroll step, based on the ScrollViewer.ViewChanged event. This causes a delay because things are not done purely in Composition. I guess it might be possible to get a smooth behavior with an improved Composition approach. Most of the calculations that are currently done manually in ViewChanged could be integrated into the CompositionAnimation. We'd still need the ViewChanged event, but a property update in the AnimationPropertySet would only be done if the actual quick return position changes. But this Composition stuff is really complicated, not sure if I can do it.

@lukasf
Copy link
Contributor

lukasf commented May 4, 2017

Well, after playing a bit with the control, I now have an improved version that is totally lag free, it runs butter smooth here! Right now I have a different PR in the making. But once that is finished, I can submit a fix for this!

@lukasf
Copy link
Contributor

lukasf commented May 31, 2017

I just created a PR for solving this!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants