Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #1106 #1108

Merged
merged 1 commit into from
Apr 19, 2017
Merged

fix #1106 #1108

merged 1 commit into from
Apr 19, 2017

Conversation

liakamp
Copy link
Contributor

@liakamp liakamp commented Apr 18, 2017

I broke it in commit 2746b5a when I removed the height of the control grid and added the template binding for height here. This commit fixes the issue

@dnfclas
Copy link

dnfclas commented Apr 18, 2017

@liakamp,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

nmetulev
nmetulev approved these changes Apr 19, 2017
View reviewed changes
Copy link
Contributor

@nmetulev nmetulev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nmetulev nmetulev requested a review from deltakosh April 19, 2017 03:42
@deltakosh deltakosh merged commit ceef571 into CommunityToolkit:dev Apr 19, 2017
@liakamp liakamp deleted the issue-1106 branch April 19, 2017 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmetulev nmetulev nmetulev approved these changes

@deltakosh deltakosh Awaiting requested review from deltakosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liakamp @dnfclas @nmetulev @deltakosh