-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use file picker for publishManifest file #120
Conversation
@@ -22,7 +22,8 @@ | |||
"build:clean": "npm run clean && npm run initdev && npm run build", | |||
"build:tasks": "npm run compile:tasks", | |||
"package": "npm run build:clean && npm run package:tasks", | |||
"clean": "git clean -fdX" | |||
"clean": "git clean -fdX", | |||
"patchvspublish": "node ./scripts/patchTaskAsDev --task=PublishVSExtension --patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pull this out of the pull request? This is what the "Update task Ids" feature of the tasks are for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for me to test my individual task by directly uploading it to my account from my machine. It helps me to see the task in the pipeline before commit. I don't always publish the full extension to test the task.
I'd like to keep these out of the standard project files. I like the env and vs code sample files, but they get packaged up with the task as well and may need cleanup. I can live with a script the project root/scripts. And install it's dependencies there too. Even better would be that they live in your fork. Or that the scripts and extension it depends on are fully integrated in the build pipeline. |
Agree, but this script is similar to what is already there under root\scripts folder and it is in root\scripts folder. They don't get packaged with the task or the extension as that folder is not part of the manifest file. I just verified by running |
Could we use the same uuidv5 trick instead of putting dev guids in the repo? Cause these are your guids, not usable by someone else etc. Which is why I rely on the tasks themselves to build and publish dev versions ;). I recently learned a cool trick which puts the vss-extension.json distributed over the task folders that way you can easily publish partial extensions. |
Because uploading the task does not publish it to marketplace, these guids will be usable by others as well as long as they test in their account. To give you more context, main reason to have this script is to test the task before committing the code.
Without that script, I cannot do 1 through 4, my whole dev workflow slows down. I need to either setup a separate pipeline for my fork or wait for PR to be merged to test my task. I would love to learn the trick you have, but to test just the task, publishing it as partial extension seems bit of overkill. After all I can just use |
Let's work on a way to service your needs. |
Maybe I can put a yaml file instead of the current build, that would make it much easier to setup the pipeline. I've been bitten by partial uploads in the past and do my testing by running the transpiled js file locally instead. Or by overwriting the task directly in the local agent's _tasks folder. |
task.json
to upload task for testing)