Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove request dependency from botframework-connector library #619

Merged
merged 6 commits into from
Nov 15, 2018

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Nov 9, 2018

Fixes #600

Description

This PR removes the request dependency in the botframework-connector library and instead uses node-fetch and form-data which should allow botframework-connector to be used in the browser.

Specific Changes

  • EmulatorApiClient, MicrosoftAppCredentials, OpenIdMetadata classes no longer use request
  • Reworked some of the private and internally called methods to use async syntax as opposed to Promises or worse, Promise-callback style

Testing

  • All current tests still passing
  • Bot works with Bot Channels Registration
  • Browser bot (webpack without errors due to botframework-connector)

@stevengum stevengum added the 4.2 December 15, 2018 Release label Nov 9, 2018
Copy link
Contributor

@justinwilaby justinwilaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small, tiny opportunities for terseness. Other than that :shipit:

@coveralls
Copy link

coveralls commented Nov 9, 2018

Pull Request Test Coverage Report for Build 2149

  • 29 of 43 (67.44%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 82.159%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-connector/src/auth/openIdMetadata.ts 13 16 81.25%
libraries/botframework-connector/src/emulatorApiClient.ts 0 5 0.0%
libraries/botframework-connector/src/auth/microsoftAppCredentials.ts 15 21 71.43%
Totals Coverage Status
Change from base Build 2139: 0.07%
Covered Lines: 2626
Relevant Lines: 3079

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2 December 15, 2018 Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants