Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botframework-connector contains Node-only Dependencies #600

Closed
justinwilaby opened this issue Nov 1, 2018 · 1 comment
Closed

botframework-connector contains Node-only Dependencies #600

justinwilaby opened this issue Nov 1, 2018 · 1 comment
Assignees
Labels
4.2 December 15, 2018 Release

Comments

@justinwilaby
Copy link
Contributor

The dependency request is a very heavy node-only dependency that prevents this package from being used in a web client. It can be easily replaced by node-fetch or some other fetch-like polyfill for the 2 calls that is it used for and would eliminate a great number of dependencies from the package.

@sgellock sgellock added 4.2 December 15, 2018 Release Approved labels Nov 6, 2018
@stevengum
Copy link
Member

Justin and I talked this afternoon. The key takeaways is that request makes the package Node specific, that request is only used in one http request and that request is a very heavy dependency. There may be other Node specific dependencies inside of the library, but request could be swapped out for a more lightweight way of conducting http requests in a pollyfilled manner, which would allow the library to be used in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.2 December 15, 2018 Release
Projects
None yet
Development

No branches or pull requests

3 participants