-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API and JavaDoc changes for Spatial Datatypes #752
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
73edf05
Added more exceptions for fuzz testing, and added some more javadocs
peterbae a09c247
fixing merge break
peterbae 3f694ff
removing log files
peterbae 243f294
javadoc changes
peterbae 537959f
gets -> returns
peterbae 862d71d
add test
peterbae d86b237
split points into two
peterbae eac074f
move error message around
peterbae 79c7e59
check neg size for all number of sizes
peterbae 81a065f
reflect comments + make internal spatial datatype file protected
peterbae 7ec6fcc
more javadoc changes
peterbae 272a729
switch lat/long
peterbae 54c5297
refactor out duplicate code
peterbae a3eb552
add null checking + change int to long
peterbae 0de6184
handle m and z value being null case and add test
peterbae b4fca56
reuse function
peterbae 3135521
move this part to other PR
peterbae 2dfb95b
reflect comment
peterbae 6f4af3d
bit more javadoc
peterbae 8aba9e6
remove StringIndexOutOfBoundsException
peterbae 589c1c0
check wkt length
peterbae a61a58b
Merge branch 'dev' into Fuzz_And_Javadoc_fix
peterbae 1d7800d
remove catching runtime exception
peterbae 1f3e437
Merge branch 'Fuzz_And_Javadoc_fix' of https://github.com/peterbae/ms…
peterbae 35d99a8
dont need those imports
peterbae e156263
use try blocks they're the best
peterbae 5ca2a83
refactor throwing illegal WKT position into a method
peterbae 2f886a0
apparently 0 and null are different, so fix that
peterbae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you missed out on the method params: x and y should be changed to latitude/longitude respectively.
Refer: MS Docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done