-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newly installed app with latest build is being required to download (and install) latest code-push build #607
Comments
Hi @faceyspacey, I think what you might be looking for is the deployment history command, which will show you whether or not you have a mandatory release in your history. If you do, then you are right that the latest release will 'inherit' the mandatory attribute. If this is indeed the cause and you'd like to change it, you can patch the release to no longer be mandatory. Does this help? |
that's amazing. thanks so much. Great work with the code push stuff by the way. really good stuff. |
@Silhouettes I have 2 quick questions for you:
I want to release a non-mandatory major release and possibly have additional small releases after it, and then at a later point mark that older major release mandatory; the reason I would do this is to avoid the app hiccups on install for the largest # of users. Maybe there is something I don't know, but the mandatory release is a very bad last resort in my case as for users who have yet to signup we continue to show an intro animation at the beginning. If you're returning to the app after a mandatory release has been made, it gets about a second through the intro animation and then the app restarts and it plays again. It's jarring and not the smooth user experience we're aiming for. I imagine if you don't have an intro animation it's not as bad, but my guess is that it's an unavoidable consequence everyone will have with a mandatory release, even if just for a split second (more like 1 or 2 seconds though). So that's why the above capability to later mark an old release as mandatory is a nice solution--it lets you limit the percentage of you're users that will experience that glitch. In addition, being able to unflag an older release as mandatory would let you fix any mistakes where an older release than the latest one shouldn't have been made mandatory, as was the case with me in the initial issue here. |
Hey @faceyspacey, in answer to your questions:
I'm not sure if the discoverability of these features is a problem - let me know if you have any ideas to improve it :) |
Hey @Silhouettes thanks so much. I wasn't sure whether |
For some time my code has been:
But I almost never pushed with mandatory mode. I'm not even sure I have, but I might have a while ago. Now, every time I build the production version of the app in Xcode, it restarts after getting the latest code. But it already has the latest code. So I'm not sure why it's doing this, or even how it detects if it has the latest code (a hash of the bundle??).
My hunch is that I must have pushed a build with a mandatory flag a while back, and now on every fresh xcode build it thinks it needs to get that, even though it has the latest code. When I do
code-push deployment ls
It saysMandatory: NO
. I thought for a second perhaps the mandatory flag was inherited somehow from a previous push.Honestly, I have no idea what's going on. I've temporarily set
mandatoryInstallMode
toON_NEXT_RESUME
, but I'd like to get to the bottom of why code-push thinks my app doesn't have the latest code when obviously it does.The text was updated successfully, but these errors were encountered: