This repository has been archived by the owner on May 7, 2024. It is now read-only.
Feature/scripting client #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 15, 2017 07:44
… for scripting service client
… literals for py 2 3 compat
…ered dictionary and we want to test against the contents in the input stream it was written to
…ountered, modified tests to reflect this change
…ql tools service side to finalize the event/parameter/response types
… code coverage with the test run
…s which would require another loop without invoking readchunk() which would block if there was no more data to read, leaving a message unprocessed in the buffer
|
@MrMeemus, |
| self.assertFalse(test_client.request_thread.isAlive()) | ||
| self.assertFalse(test_client.response_thread.isAlive()) | ||
| self.assertEqual(threading.active_count(), 1) | ||
|
|
||
| # Response thread should have reach EOF during test execution which should end the response thread. | ||
|
|
There was a problem hiding this comment.
Missing an assert after the comment? #Resolved
There was a problem hiding this comment.
|
|
||
| test_client.shutdown() | ||
| self.assertEqual(threading.active_count(), 1) | ||
| # Disabling this test in case this scenario is valid in the future |
There was a problem hiding this comment.
Disabling this test in case this scenario is valid in the future [](start = 4, length = 66)
Can we enable the test as passing with the current behavior. Then, when the scenario is valid, it will fail and we can update the test? #Resolved
There was a problem hiding this comment.
|
Nice! In reply to: 289101128 [](ancestors = 289101128) |
|
|
| @@ -2,3 +2,5 @@ enum34==1.1.6 | |||
| future==0.16.0 | |||
| pip==9.0.1 | |||
| setuptools==30.4.0 | |||
| coverage==4.3.4 | |||
There was a problem hiding this comment.
remove extra line above #Resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting initial PR to get the show going.
There is one test issue when ran on mac regarding the way mac treats CRLF in a text file. Investigating a fix now.