Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable SourceLink for FSharp.Core.pdb #5682

Closed
ctaggart opened this issue Sep 21, 2018 · 3 comments
Closed

enable SourceLink for FSharp.Core.pdb #5682

ctaggart opened this issue Sep 21, 2018 · 3 comments
Labels
Area-Library Issues for FSharp.Core not covered elsewhere Feature Improvement
Milestone

Comments

@ctaggart
Copy link
Contributor

Following up on #294, please enable SourceLink for the published FSharp.Core.pdb files so that we can debug into the source code just like the rest of dotnet core.

image

@cartermp cartermp added Area-Library Issues for FSharp.Core not covered elsewhere Feature Improvement labels Oct 9, 2018
@cartermp cartermp added this to the Unknown milestone Oct 9, 2018
@7sharp9
Copy link
Contributor

7sharp9 commented Feb 21, 2019

We could do with this asap, stepping through F# code as C# is not fun in the debugger. Im sure people contributing to the compiler and tools find this painful too as you have to read C# code and cross reference it with the repo here to get a clear picture of what happening.

@baronfel
Copy link
Member

This should just be a matter of adding a dependency to Microsoft.SourceLink.Github, version 1.0.0-beta2-19367-01 and setting a few additional properties in the FSharp.Core Project File (or maybe the FSharpBuild.Directory.Props, depending on conventions?):

    <!-- Optional: Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
    <PublishRepositoryUrl>true</PublishRepositoryUrl>
 
    <!-- Optional: Embed source files that are not tracked by the source control manager in the PDB -->
    <EmbedUntrackedSources>true</EmbedUntrackedSources>
  
    <!-- Optional: Build symbol package (.snupkg) to distribute the PDB containing Source Link -->
    <IncludeSymbols>true</IncludeSymbols>
    <SymbolPackageFormat>snupkg</SymbolPackageFormat>

@cartermp
Copy link
Contributor

I think #9948 should resolve this issue.

@cartermp cartermp modified the milestones: Unknown / not bug, F# 5, 16.8 Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Library Issues for FSharp.Core not covered elsewhere Feature Improvement
Projects
None yet
Development

No branches or pull requests

4 participants