Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sporadic failure pushing images to ACR #666

Closed
dbafromthecold opened this issue Nov 29, 2018 · 5 comments · Fixed by #705
Closed

Sporadic failure pushing images to ACR #666

dbafromthecold opened this issue Nov 29, 2018 · 5 comments · Fixed by #705
Assignees
Labels
Milestone

Comments

@dbafromthecold
Copy link

Repro steps:
Running through the Docker: ACR Tasks: Build Image in VS Code
Error is generated when trying to push image to Azure

Action: vscode-docker.acr.quickBuild
Error type: SourceLocationNotFound
Error Message: The provided source location 'source/201811290000/20791c20-86a1-41c6-ae5c-07b8473fe461.tar.gz' is invalid or doesn't exists. Please use 'GetBuildSourceUploadUrl' to get a valid location to upload the source.

Version: 0.4.0
OS: win32

@StephenWeatherford
Copy link
Contributor

@dbafromthecold Does this reproduce every time? Or does it sometimes succeed? Anything else you could test us that might help us narrow down the issue? Thx.

@dbafromthecold
Copy link
Author

@StephenWeatherford It's failed each time I've tried. Am working with a simple dockerfile (to test): -

`FROM mcr.microsoft.com/mssql/server:2019-CTP2.0-ubuntu

RUN /opt/mssql/bin/mssql-conf set sqlagent.enabled true

CMD /opt/mssql/bin/sqlservr`

image

I can't see any other errors/logs to provide any further information I'm afraid.

@rosanch
Copy link
Collaborator

rosanch commented Dec 8, 2018

Sorry. Closed this by mistake. It appears to be an error with one of the libraries being used in Linux machines. I'm looking into this issue.

@rosanch rosanch added P1 and removed P2 labels Dec 8, 2018
@StephenWeatherford
Copy link
Contributor

@rosanch According to the error info above, this was on Win32, not Linux...? It seems suspicious to me that the provided "source location" in the error is a relative path, shouldn't it be absolute?

#701 also shows this same error, although I wasn't able to repro.

@StephenWeatherford
Copy link
Contributor

@rosanch Actually, I think I know the cause:

In uploadSourceCode, you're not waiting for the blob upload to complete:

    blob.createBlockBlobFromLocalFile(blobInfo.containerName, blobInfo.blobName, tarFilePath, (): void => { });

@StephenWeatherford StephenWeatherford modified the milestones: 0.6.0, 0.5.0 Dec 12, 2018
rosanch added a commit that referenced this issue Dec 12, 2018
StephenWeatherford pushed a commit that referenced this issue Dec 13, 2018
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners
@StephenWeatherford StephenWeatherford changed the title Error when pushing image to ACR Sporadic failure pushing images to ACR Dec 13, 2018
rosanch added a commit that referenced this issue Feb 1, 2019
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners

* Fixes #662

* Minor ACR casing fixes
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants