Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker.acr.pullimage issue #648

Closed
cargohec opened this issue Nov 25, 2018 · 3 comments · Fixed by #705
Closed

docker.acr.pullimage issue #648

cargohec opened this issue Nov 25, 2018 · 3 comments · Fixed by #705
Assignees
@rosanch
Labels
P1
Milestone
0.6.0

Comments

@cargohec
Copy link

Repro steps:

Tried to pull bitnami/java image from Azure

Action: vscode-docker.acr.pullImage
Error type: TypeError
Error Message: Path must be a string. Received undefined

Version: 0.4.0
OS: darwin

image
@StephenWeatherford StephenWeatherford added this to the 0.5.0 milestone Nov 26, 2018
@rosanch
Copy link
Collaborator

rosanch commented Dec 4, 2018

PR #656

@rosanch
Copy link
Collaborator

rosanch commented Dec 7, 2018

Hi @cargohec,
I haven't been able to reproduce this exact issue. However, there was an issue on pullimage. The fix was merged today to master(PR #565). That may help. If after that, the error persists please let me know. Meanwhile, is there any extra information you could provide that may help me to reproduce this issue. As of now, the one thing I can think of is that is related to the os, I'll try to test it on Darwin to see if that reproduces the error.

rosanch added a commit that referenced this issue Dec 12, 2018
@rosanch
Fixes the following issues :
0b10d1a 
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648
@rosanch
Copy link
Collaborator

rosanch commented Dec 12, 2018

Fixed by #705

@rosanch rosanch closed this as completed Dec 12, 2018
@rosanch rosanch mentioned this issue Dec 12, 2018
Merged
StephenWeatherford pushed a commit that referenced this issue Dec 13, 2018
@rosanch @StephenWeatherford
ACR Fixes (Logs & Docker Pull) (#705)
e1d6d42 
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners
rosanch added a commit that referenced this issue Feb 1, 2019
@rosanch
Fixes hovering colors over the digest, and minor typos. (#710)
a45a9a6 
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners

* Fixes #662

* Minor ACR casing fixes
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rosanch rosanch

Labels
P1
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

ACR Fixes (Logs & Docker Pull) microsoft/vscode-docker
3 participants
@StephenWeatherford @cargohec @rosanch