Skip to content

Commit

Permalink
Fixes hovering colors over the digest, and minor typos. (#710)
Browse files Browse the repository at this point in the history
* Fixes the following issues :
	Unhandled error if you cancel saving Azure log #639
	Save Azure log dialog shows "log..log" as the filename extension #640
	docker.acr.pullimage issue #648

* fixes #666

* PR #705 Fixes

* Adds telemitry to the ACR logs table listeners

* Fixes #662

* Minor ACR casing fixes
  • Loading branch information
rosanch committed Feb 1, 2019
1 parent 201f8a3 commit a45a9a6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions commands/azureCommands/delete-image.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,14 @@ export async function untagAzureImage(context?: AzureImageTagNode): Promise<void
image = new AzureImage(repo, wholeName[1]);
}

const untag: vscode.MessageItem = { title: "Untag" };
const shouldDelete = await ext.ui.showWarningMessage(
`Are you sure you want to untag '${image.toString()}'? This does not delete the manifest referenced by the tag.`,
{ modal: true },
DialogResponses.deleteResponse,
untag,
DialogResponses.cancel);

if (shouldDelete === DialogResponses.deleteResponse) {
if (shouldDelete === untag) {
await acrTools.untagImage(image);
vscode.window.showInformationMessage(`Successfully untagged '${image.toString()}'`);

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@
},
{
"command": "vscode-docker.acr.pullImage",
"title": "Pull tag from Azure",
"title": "Pull Tag from Azure",
"category": "Docker"
},
{
Expand Down
4 changes: 2 additions & 2 deletions style/acr-logs/stylesheet.css
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ main {
.tooltip .tooltiptext {
box-sizing: border-box;
display: none;
background-color: var(--vscode-editor-foreground);
color: var(--vscode-activityBar-background);
background-color: var(--vscode-list-hoverBackground);
color: var(--vscode-list-foreground);
text-align: center;
padding: 5px 16px;
position: absolute;
Expand Down

0 comments on commit a45a9a6

Please sign in to comment.