Format on save doesn't work anymore

[tapir]

I've just noticed that go doesn't automatically format anymore.
I've also noticed that now go.formatOnSave is deprecated hence I'vee switched to editor.formatOnSave: true yet it still doesn't work.

[ramya-rao-a]

Can you try

"[go]": {
   "editor.formatOnSave": true
}

Remember that Workspace Settings will override Global/User Settings.

Can you also try on a smaller package separately?
If the formatter takes more than 750ms then it is skipped as slow processes like that can end up adding edits to file after manual edits from user

[tapir]

Hi,

tried above setting on 2 different computer (windows and linux) with multiple size projects including very small ones. still no luck.

[tapir]

Actually, now I notice, other facilities such as automatically arranging imports, go to definition etc don't work either. Here is my global settings file (there is no workspace specific setting)

// Place your settings in this file to overwrite the default settings
{
    "go.lintTool": "gometalinter",
    "git.confirmSync": false,
    "extensions.ignoreRecommendations": true,
    "workbench.startupEditor": "newUntitledFile",
    "git.autofetch": true,
    "[go]": {
        "editor.formatOnSave": true
     }
}

[gngchrs]

Release notes say go.formatOnSave is deprecated. Tried the above setting by @ramya-rao-a but still no luck.
Also tried adding "go.formatFlags": ["-w"], since its using goreturns, but no luck.
Turns out the -w flag is ignored by design

Output on VS CODE only shows that go vet and go lint have been run

Using MacOS

[ramya-rao-a]

Does manual formatting work?

[tapir]

It does, yes.

[esinek]

Same here. Running gofmt from the cmd line works. Save on format isn't working. Option-Shift-F (the default format file in MacOS, which, I believe should use gofmt) doesn't format file either.
When I select some lines and do Cmd-K, Cmd-F, I get the following message:
Sorry, but there is no formatter for 'go'-files installed.
this is with the following:

    "editor.formatOnSave": true,
    "go.formatTool": "gofmt",
    "[go]": {
        "editor.formatOnSave": true
    }

looking at the output console there is no gofmt as mentioned by @gangachris :

Finished running tool: /Users/me/workspace/myapp/bin/golint

Finished running tool: /usr/local/go/bin/go vet ./...

Finished running tool: /usr/local/go/bin/go build -i -o /var/folders/1z/3p0xvm1125941j03c7jr8vm7wfr3q/T/go-code-check mystuff

NOTE: uninstalled and installed 0.6.69 from VSIX and it's working again

[ramya-rao-a]

Ok, then it's the case of formatter taking more time than 750ms.

I am currently on vacation. A few things you can do

• stay on the current version, run manual formatting when needed. When I get back, I can look at bringing back the old behavior as a fall back, but it will bring back the 5 issues that the new model is fixing
• or you can revert to the previous version. Get the vsix file from the previous release https://github.com/Microsoft/vscode-go/releases/tag/0.6.69 and run "code --install-extension Go-0.6.69.vsix" and then disable aauto update of extensions

[tapir]

Ok thanks.

I'm not convinced it's the 750ms issue though because even a very simple hello world can't be formatted on my computer.

Have a nice vacation.

[philipithomas]

I'm also having this issue all of a sudden. No formatting or goimports being run.

[gngchrs]

@philipithomas had to revert to 0.6.69 like @ramya-rao-a suggested.

[ramya-rao-a]

@esinek manual formatting shldnt be affected. I don't recall the keyboard shortcut in Mac for formatting. Can you try the formatting cmd from the cmd pallet or right click on editor and choose "format document"

@tapir That does sound suspicious. Can you drop a few console.log() statements in the file "$HOME/.vscode/extensions/lukehoban.go-0.6.70/out/src/goFormat.js" and see if formatting provider is being called?

• Add console.log(timeTaken); just before the return resolve(textEdits);.
• Save the file and reload VS Code
• Edit a Go file and save it.
• Check the console for the logs. Help -> Toggle Developer Tools -> Console

[egorovli]

Also missing go.formatOnSave which was fine until I had a variable name collision with some package which gets automatically imported :(

config is defined in main.go, trying to save routes.go which uses this config variable, but instead package github.com/prometheus/common/config gets imported.

Update

Fixed it changing settings to:

"go.formatTool": "goimports"

[lunny]

here only gofmt work, but goimports and goreturns didn't work.

[andrevoget]

I have the same problem. Neither

"go.formatTool": "gofmt"
"go.formatTool": "goimports"
"go.formatTool": "goreturns"

work all of a sudden. Installing 0.6.69 fixed the problem.

@ramya-rao-a Keep up the good work! Please don't interrupt your well deserved vacation as there is a workaround.