This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Do not suggest function parameters if passing it as an argument #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
Jul 16, 2018
|
True, I missed that. |
ramya-rao-a
suggested changes
Jul 17, 2018
ramya-rao-a
approved these changes
Jul 17, 2018
ramya-rao-a
approved these changes
Jul 17, 2018
|
Never mind, I've added the tests. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the suggestion: #1779 (comment)
This PR disables suggesting function parameters if passing the suggestion as an argument. If cursor ends with
,or)it skips parameter suggestion.For more info: #1779