Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to filter PR commits by commit-hash range #505

Open
fluffynuts opened this issue Sep 19, 2018 · 2 comments
Open

Ability to filter PR commits by commit-hash range #505

fluffynuts opened this issue Sep 19, 2018 · 2 comments
Labels
feature-request Request for new features or functionality

Comments

@fluffynuts
Copy link

On pull requests which are undergoing review, where the requestor has been attending to requested changes, it's really useful at GitHub.com to be able to filter by commit -- that is, to be able to view a ranged subset of commits for a PR so that only the latest changes can be observed to decide on approval for a PR which has undergone review and subsequent work.

At the moment, this would even be good enough through a command-palette interaction, for example, running the command "GitHub Pull Requests: Filter Current Request" and then getting a list of the commits, by hash (with the beginning of the commit message) in a list where one could ctrl-click or shift-click to select ranges of commits of interest, or just click to select a single commit of interest.

@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Sep 19, 2018
@alexr00
Copy link
Member

alexr00 commented Nov 10, 2020

Duplicate of #363

@alexr00 alexr00 marked this as a duplicate of #363 Nov 10, 2020
@alexr00 alexr00 closed this as completed Nov 10, 2020
@kevinvalk
Copy link

Proposing to reopen this one.

In our case we have a merge squash approach with linear commit history. This means that we sometimes need to merge main back into the PR. This will cause 1 or more commits to be part of the "since last reviewed" part, but as they came from main they were already reviewed.

On GitHub there is a way to review only a subset of commits in a PR.
image

The blue is the selected commits and using the "Show changes since your last review" will select all commits after your last review. Using the "hold shift + click to select a range" feature you can select any arbitrary subset.

It would be amazing to exclude certain commits from the review. I am thinking maybe there could be a button or highlight in the "> commits" section to indicate which commits are shown and exclude certain commits through a button, right click context, etc?

@alexr00 alexr00 reopened this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants