You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On pull requests which are undergoing review, where the requestor has been attending to requested changes, it's really useful at GitHub.com to be able to filter by commit -- that is, to be able to view a ranged subset of commits for a PR so that only the latest changes can be observed to decide on approval for a PR which has undergone review and subsequent work.
At the moment, this would even be good enough through a command-palette interaction, for example, running the command "GitHub Pull Requests: Filter Current Request" and then getting a list of the commits, by hash (with the beginning of the commit message) in a list where one could ctrl-click or shift-click to select ranges of commits of interest, or just click to select a single commit of interest.
The text was updated successfully, but these errors were encountered:
In our case we have a merge squash approach with linear commit history. This means that we sometimes need to merge main back into the PR. This will cause 1 or more commits to be part of the "since last reviewed" part, but as they came from main they were already reviewed.
On GitHub there is a way to review only a subset of commits in a PR.
The blue is the selected commits and using the "Show changes since your last review" will select all commits after your last review. Using the "hold shift + click to select a range" feature you can select any arbitrary subset.
It would be amazing to exclude certain commits from the review. I am thinking maybe there could be a button or highlight in the "> commits" section to indicate which commits are shown and exclude certain commits through a button, right click context, etc?
On pull requests which are undergoing review, where the requestor has been attending to requested changes, it's really useful at GitHub.com to be able to filter by commit -- that is, to be able to view a ranged subset of commits for a PR so that only the latest changes can be observed to decide on approval for a PR which has undergone review and subsequent work.
At the moment, this would even be good enough through a command-palette interaction, for example, running the command "GitHub Pull Requests: Filter Current Request" and then getting a list of the commits, by hash (with the beginning of the commit message) in a list where one could ctrl-click or shift-click to select ranges of commits of interest, or just click to select a single commit of interest.
The text was updated successfully, but these errors were encountered: