-
Notifications
You must be signed in to change notification settings - Fork 28.7k
-
Notifications
You must be signed in to change notification settings - Fork 28.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem Tab is all corrupted with Typescript Problems #56371
Comments
Just an update. I tried disabling the TsLint extension and the problem still exists. |
Have similar problem for ruby files (using Ruby extenstion). And for typescript files too. |
Downgrading to 1.25.1 fixes it. You can get it here: https://code.visualstudio.com/updates/v1_25. Disable automatic updates by putting "update.channel": "none" in your user settings. |
Seeing same thing in Dart. I'm seeing stale errors, and clicking them doesn't navigate anywhere, and the same scrollbar that does nothing (which shouldn't be displayed, because the list is short). |
@sandy081 since this happens with many languages this looks like a general problem with the view. Might be even Electron 2.0 related due to the scrolling issues. |
Related to #56317 by the looks of it. |
Can anyone help in providing the steps to reproduce this (possibly with some sample file)? |
Interestingly I haven't seen it on my Windows PC today (it was MacBook I saw it on). When I next see it (either here, or on the MB I'll see if I can do it on-demand and provide any details I can). |
Well, I saw it on Windows: Same thing - the top entries have lost their file (they should be in the I reviewed the language server logs, and the errors all look normal to me. They all came through with the correct path (and the casing is all correct, etc.). I can't figure out how to reliably repro though, just seems to happen after a while. I did find lots of errors in the dev console (full log): Here's the unique ones:
|
@DanTup Thanks for the logs. I think I understand the issue now. |
There is an exception while rendering a problem entry and hence it is not getting removed. This is also the reason why the interaction is broken. This exception is caused due to the timing issue. Just before the problem entry is rendered, its parent is removed from the tree. While the problem entry is being rendered, I am accessing its parent using tree navigator (assuming that parent should exist always) to check for the quick fixes. Since the parent is removed already it does not exist and causing this exception. Fix is to not to access the parent through tree navigator, instead from the model which will assure it always exists. |
@sandy081 I've wrapped tree Pushed to master, not for the recovery. |
Related to #56317 Some comments of #56317 also descripes this error. In my case (just for the log here) a ionic angular project in
I don't know the steps to reproduce it. e.g. after restart of vs code the bug disapears. |
@Domvel Please check if there are any errors in the Dev tools console when you are in this state. Use command |
Code reviewed 26bd850 |
Verified in 1.26.1-stable |
@sandy081 Sorry, I should do this for an issue next time. Currently, the bug no longer appears. Because I want log him. 😄 Typical debugging issue. I'll work on |
@sandy081 One second later of my post above the bug appeared. Easy trick to reproduce it. e.g. trailing commas (if tslint is enabled for this). Just typ a lot of commas and remove it again. At last add one comma again. Voila, here it is. Click here to view the log.ERR Cannot read property 'hasFixes' of null: TypeError: Cannot read property 'hasFixes' of null at t [as constructor] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3575:721) at t.create (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:111:339) at e._createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1378:703) at e.createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1377:959) at e.renderMarkerElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:926) at e.renderElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:218) at e.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:99) at t.refreshViewItem (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:967:916) at t.onRefreshItem (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:967:754) at t.e.onRemoveItems (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:344:585) at t.onItemChildrenRefreshed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:964:920) at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:552) at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:552) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:174:517 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:327:463 at n.Class.derive._creator.then (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:366) at s (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:327:416) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:319:795 at new n.Class.derive._oncancel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:625) at e.run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:319:669) at t.e.refreshChildren (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:327:497) at t.e.doRefresh (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:327:751) at t.e.refresh (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:327:893) at e.refresh (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:335:201) at i.e.refresh (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:981:186) at t.refreshPanel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4439:977) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4443:303 at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:195:402 at Object.g [as _notify] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:151:729) at Object.enter (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:155:61) at n.Class.derive._oncancel._run (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:156:902) at n.Class.derive._oncancel._completed (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:156:343) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:195:461 log.ts:171 ERR Cannot read property 'hasFixes' of null: TypeError: Cannot read property 'hasFixes' of null at t [as constructor] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3575:721) at t.create (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:111:339) at e._createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1378:703) at e.createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1377:959) at e.renderMarkerElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:926) at e.renderElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:218) at e.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:99) at e.insertInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:917) at t.insertItemInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:976:302) at t.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:959:133) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:954:429 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:392:566 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at t._setState (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:255:372) at t.setScrollPositionNow (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253:889) at t._onMouseWheel (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:396:706) at HTMLDivElement.n (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:395:652) log.ts:171 ERR Cannot read property 'hasFixes' of null: TypeError: Cannot read property 'hasFixes' of null at t [as constructor] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3575:721) at t.create (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:111:339) at e._createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1378:703) at e.createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1377:959) at e.renderMarkerElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:926) at e.renderElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:218) at e.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:99) at e.insertInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:917) at t.insertItemInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:976:302) at t.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:959:133) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:954:429 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:392:566 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at t._setState (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:255:372) at t.setScrollDimensions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253:438) at t.setScrollDimensions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:394:818) at t.set [as viewHeight] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:962:347) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:958:653) at i.e.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:980:699) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4438:265) at c.t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4916:289) at c.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4966:150) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4499:832) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4492:290 at n.Class.define.cancel.done (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:234) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4492:265 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:387:138 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at r (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:181:588) log.ts:171 ERR Cannot read property 'hasFixes' of null: TypeError: Cannot read property 'hasFixes' of null at t [as constructor] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:3575:721) at t.create (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:111:339) at e._createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1378:703) at e.createInstance (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:1377:959) at e.renderMarkerElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:926) at e.renderElement (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4434:218) at e.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:99) at e.insertInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:951:917) at t.insertItemInDOM (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:976:302) at t.render (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:959:272) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:954:429 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:392:566 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at t._setState (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:255:372) at t.setScrollDimensions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:253:438) at t.setScrollDimensions (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:394:818) at t.set [as viewHeight] (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:962:347) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:958:653) at i.e.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:980:699) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4438:265) at c.t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4916:289) at c.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4966:150) at t.layout (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4499:832) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4492:290 at n.Class.define.cancel.done (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:158:234) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:4492:265 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:387:138 at e.fire (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:172:532) at r (file:///C:/Program Files/Microsoft VS Code/resources/app/out/vs/workbench/workbench.main.js:181:588)In short |
@Domvel This will be fixed in 1.26.1 |
The other thing that happens when it is in this state is the scroll in the problem window is all wired. It is almost like the first half is floating on top.
Steps to Reproduce:
Unfortunately I can't find the exact steps to reproduce, but it has happened a few times this morning. From I what I can tell it seems occurs when either a large block of problem code is commented out or using a couple of TypeScript fixers back to back.
This was not happening in the previous version: 1.25.1.
The text was updated successfully, but these errors were encountered: