-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Today's 1.29 Insiders Breaks Extensions #60168
Comments
Note that this didn't break all of my extensions, only some:
|
Same issue here, using Insiders
|
same: Version: 1.29.0-insider (user setup) |
Cannot reproduce in stable 1.28 and the comments above are all referring to the insider version. |
This comment has been minimized.
This comment has been minimized.
Same here, broke liximomo.sftp although I don't see any errors in the logs. Version: 1.29.0-insider (user setup) |
Most probably a dup of #60190 ( |
Looks like some loader/require hooks changes had broken node globals. Here is a simple way to reproduce the issue: extension.js require('./initGlobals');
console.log(myGlobal); // <-- breaks, but used to work initGlobals.js global.myGlobal = 'test'; |
Had this issue as well, it completely broke the Microsoft Python extension. |
This might be related to us now using cached data for extensions |
Workaround is to start with |
The is fixed in 1.29.0 |
Logs:
The text was updated successfully, but these errors were encountered: