Extensions using lodash no longer load in Insiders (issue with global)

[StephenWeatherford]

Issue Type: Bug

This is a regression - it used to work fine in Insiders, and it still works fine in non-Insiders 1.27.2.

1. git clone https://github.com/Microsoft/vscode-cosmosdb.git
2. cd vscode-cosmos
3. npm install
4. load in vscode Insiders and press F5
   !) Extension fails to activate due to error here:

node_modules\gremlin\node_modules\lodash\index.js:718:
var arrayProto = Array.prototype, <<<<<<<<<<< Array is undefined
TypeError: Cannot read property 'prototype' of undefined
at runInContext (C:\Users\stephwe\Repos\vscode-cosmosdb\node_modules\gremlin\node_modules\lodash\index.js:718:28)
at Object. (C:\Users\stephwe\Repos\vscode-cosmosdb\node_modules\gremlin\node_modules\lodash\index.js:12320:11)
at Object. (C:\Users\stephwe\Repos\vscode-cosmosdb\node_modules\gremlin\node_modules\lodash\index.js:12351:3)
at Object. (C:\Users\stephwe\Repos\vscode-cosmosdb\node_modules\gremlin\node_modules\lodash\index.js:12353:3)
at Module.t._initNodeRequire.i._compile (c:\Users\stephwe\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\out\vs\loader.js:16:65)

This appears to have to do with the definition of "global" inside module loading. Here's the value of global in Insiders inside lodash:

And here it's value in regular vscode 1.27.2:

VS Code version: Code 1.27.2 (f46c4c4, 2018-09-12T16:57:45.963Z)
OS version: Windows_NT ia32 10.0.17763

System Info

Item	Value
CPUs	Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.73GB (18.23GB free)
Process Argv	C:\Users\stephwe\Repos\vscode-docker.vscode-test\stable\Code.exe --folder-uri file:///c%3A/Users/stephwe/Repos/vscode-docker
Screen Reader	no
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
tslint	eg2	1.0.39
vscode-antlr4	mik	2.0.4
vscode-azurestorage	ms-	0.4.2
vscode-cosmosdb	ms-	0.8.0
azure-account	ms-	0.4.3
csharp	ms-	1.16.2
vscode-docker	Pet	0.3.1

[DonJayamanne]

I believe this is the cause for Python Extension not loading as well #60196 (again related to global variable Reflect that's updated by reflect-metadata).
I.e. issue with global, possibly in loader.js

[bpasero]

/duplicate #60168

[vscodebot]

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

[StephenWeatherford]

Fixed for me, thanks!