Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated app-center CLI docs to reflect issue found #334

Merged
merged 3 commits into from
Nov 7, 2018

Conversation

hilts-vaughan
Copy link
Contributor

@hilts-vaughan hilts-vaughan commented Oct 31, 2018

microsoft/appcenter-cli#287

This is mostly to address the above.

@jwargo jwargo requested review from Zakeelm and amchew and removed request for Zakeelm October 31, 2018 13:31
@jwargo
Copy link
Contributor

jwargo commented Oct 31, 2018

@hilts-vaughan thanks for submitting this, I'll have the associated PM review it. One change I see that needs to be made is that we can't have here links in the docs as that doesn't work for people using screen readers. I'm going to make that small change.

@hilts-vaughan
Copy link
Contributor Author

Thanks!

@amchew
Copy link
Contributor

amchew commented Nov 7, 2018

Hi @hilts-vaughan, thank you for taking the initiative to make the changes! I’m Amanda, the PM for CLI, nice to e-meet you. I’ve approved the changes and will merge the PR.

@amchew amchew merged commit 0e940c7 into MicrosoftDocs:live Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants