Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add URL for monitoring extension #37045

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Add URL for monitoring extension #37045

merged 2 commits into from
Aug 14, 2019

Conversation

bragi92
Copy link
Contributor

@bragi92 bragi92 commented Aug 13, 2019

No description provided.

@PRMerger14
Copy link
Contributor

@bragi92 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Jak-MS Jak-MS added the aq-pr-triaged tracking label for the PR review team label Aug 13, 2019
MGoedtel
MGoedtel suggested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@MGoedtel MGoedtel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend rewriting the statement to - Redirect URI: Two Web application types need to be created. The first base URL value should be https://afd.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html and the second base URL value should be https://monitoring.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html.
Thanks!

@ktoliver
Copy link
Contributor

@bragi92 Would you make the recommended updates to the PR? Thanks.

@PRMerger20
Copy link
Contributor

@bragi92 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@bragi92
Copy link
Contributor Author

bragi92 commented Aug 14, 2019

@bragi92 Would you make the recommended updates to the PR? Thanks.

Recommend rewriting the statement to - Redirect URI: Two Web application types need to be created. The first base URL value should be https://afd.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html and the second base URL value should be https://monitoring.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html.
Thanks!

Updated. Thanks for the feedback.

@ktoliver ktoliver assigned MGoedtel and unassigned MGoedtel Aug 14, 2019
@MGoedtel
Copy link
Contributor

Thanks for making the change and it looks good. #sign-off

@Jak-MS Jak-MS merged commit 008eebf into MicrosoftDocs:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGoedtel MGoedtel Awaiting requested review from MGoedtel

Assignees

@MGoedtel MGoedtel

Labels
aq-pr-triaged tracking label for the PR review team Azure-Monitor/svc Change sent to author ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bragi92 @PRMerger14 @ktoliver @PRMerger20 @MGoedtel @PRMerger13 @Jak-MS