Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL for monitoring extension #37045

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@bragi92
Copy link
Contributor

commented Aug 13, 2019

No description provided.

@PRMerger14

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@bragi92 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@MGoedtel
Copy link
Contributor

left a comment

Recommend rewriting the statement to - Redirect URI: Two Web application types need to be created. The first base URL value should be https://afd.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html and the second base URL value should be https://monitoring.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html.
Thanks!

@ktoliver

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@bragi92 Would you make the recommended updates to the PR? Thanks.

@PRMerger20

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@bragi92 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@PRMerger20 PRMerger20 requested a review from MGoedtel Aug 14, 2019

@bragi92

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@bragi92 Would you make the recommended updates to the PR? Thanks.

Recommend rewriting the statement to - Redirect URI: Two Web application types need to be created. The first base URL value should be https://afd.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html and the second base URL value should be https://monitoring.hosting.portal.azure.net/monitoring/Content/iframe/infrainsights.app/web/base-libs/auth/auth.html.
Thanks!

Updated. Thanks for the feedback.

@ktoliver ktoliver assigned MGoedtel and unassigned MGoedtel Aug 14, 2019

@MGoedtel

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Thanks for making the change and it looks good. #sign-off

@Jak-MS Jak-MS merged commit 008eebf into MicrosoftDocs:master Aug 14, 2019

1 check passed

license/cla All CLA requirements met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.