Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-analyzer-macos-linux.md #51

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Conversation

EdgarPMIA
Copy link
Contributor

Adding a note to clarify that the report.html file is generated only when using the Python-based version of the client analyzer. I looked for the file but couldn't find. When I used the Python-based version of the client analyzer, I confirmed the file was generated.

Adding a note to clarify that the report.html file is generated only when using the Python-based version of the client analyzer. I looked for the file when using the binary version of the tool but after I rant the Python-based version I confirmed the file was generated.
Copy link
Contributor

Learn Build status updates of commit 8555edc:

✅ Validation status: passed

File Status Preview URL Details
defender-endpoint/run-analyzer-macos-linux.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@EdgarPMIA
Copy link
Contributor Author

Anything additional I need to do to finish the update on this article? thanks!

@siosulli
Copy link
Contributor

Anything additional I need to do to finish the update on this article? thanks!

Thanks @EdgarPMIA! What you added looks great. I actually find the original sentence a bit confusing :).

"The main HTML output file that contains the findings and guidance that the analyzer script run on the machine can produce"

If we updated it to this - does this make sense:

"The main HTML output file that contains the findings and guidance from running the client analyzer tool on the device. This file is only generated when running the Python-based version of the client analyzer tool. "

@EdgarPMIA
Copy link
Contributor Author

@siosulli Hi, yes, I think is perfect 👌

@siosulli
Copy link
Contributor

Great! I will make the update and go ahead merge. Thank you!

Copy link
Contributor

Learn Build status updates of commit df26a6e:

✅ Validation status: passed

File Status Preview URL Details
defender-endpoint/run-analyzer-macos-linux.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit f18fc7f:

✅ Validation status: passed

File Status Preview URL Details
defender-endpoint/run-analyzer-macos-linux.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@siosulli siosulli merged commit a129a55 into MicrosoftDocs:public Jun 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants