Edit hello world section and add more images #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reflecting the discussion from today's sync
Updated build-and-run.md as part of PR 2907.
This comment has been minimized.
This comment has been minimized.
|
Docs Build status updates of commit 5b885c2:
|
|
Docs Build status updates of commit 02f26de:
|
Updated Troubleshooting section for minor style edits.
This comment has been minimized.
This comment has been minimized.
heath-hamilton
suggested changes
Apr 27, 2021
Comment on lines
174
to
176
|
|
||
| * Something went wrong | ||
| * Manifest parsing has failed |
There was a problem hiding this comment.
@v-vrajaraman The message only reads, "Manifest parsing has failed."
Fixed Heath's comments
|
Docs Build status updates of commit 72849a2:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| msteams-platform/build-your-first-app/build-and-run.md | View | Details | |
| msteams-platform/TOC.yml | ✅Succeeded | View | |
| msteams-platform/assets/icons/vsc-toolkit.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/VSC-install-toolkit.PNG | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/app-in-cloud.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/personal-tab-tutorial-content.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/personal-tab-tutorial-updated-theme.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/teams-client-bot.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/teams-client-helloworld.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-01.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-02.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-03.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-04.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-05.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-appstudio.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-01.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-02.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-03.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-04.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-05.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-07.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-ngrok-06.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-install-08.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-install.png | ✅Succeeded | View | |
| msteams-platform/assets/images/tabs/channel-tab-tutorial-content-installed.PNG | ✅Succeeded | View | |
| msteams-platform/assets/images/tabs/channel-tab-tutorial-content.PNG | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-bot.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-channel-tab.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-first-app-overview.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-messaging-extension.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-personal-tab.md | ✅Succeeded | View | |
| msteams-platform/tabs/how-to/using-teams-client-sdk.md | ✅Succeeded | View | |
| msteams-platform/task-modules-and-cards/cards/cards-format.md | ✅Succeeded | View |
msteams-platform/build-your-first-app/build-and-run.md
- Line 66, Column 103: [Warning-file-not-found]
Invalid file link: '~/tutorials/get-started-dotnet-app-studio.md/'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
|
I have fixed all comments. Please approve the PR for merge. |
heath-hamilton
previously approved these changes
Apr 27, 2021
There was a problem hiding this comment.
@v-vrajaraman I made some final comments to address the remaining issues. I believe you can commit these suggestions and merge without me having to review again.
msteams-platform/build-your-first-app/build-first-app-overview.md
Outdated
Show resolved
Hide resolved
|
Docs Build status updates of commit 25c2038:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| msteams-platform/build-your-first-app/build-and-run.md | View | Details | |
| msteams-platform/TOC.yml | ✅Succeeded | View | |
| msteams-platform/assets/icons/vsc-toolkit.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/VSC-install-toolkit.PNG | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/app-in-cloud.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/personal-tab-tutorial-content.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/personal-tab-tutorial-updated-theme.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/teams-client-bot.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/teams-client-helloworld.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-01.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-02.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-03.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-04.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-05.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-appstudio.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-01.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-02.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-03.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-04.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-05.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-07.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-bots-ngrok-06.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-install-08.png | ✅Succeeded | View | |
| msteams-platform/assets/images/build-your-first-app/vscode-teams-toolkit-install.png | ✅Succeeded | View | |
| msteams-platform/assets/images/tabs/channel-tab-tutorial-content-installed.PNG | ✅Succeeded | View | |
| msteams-platform/assets/images/tabs/channel-tab-tutorial-content.PNG | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-bot.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-channel-tab.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-first-app-overview.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-messaging-extension.md | ✅Succeeded | View | |
| msteams-platform/build-your-first-app/build-personal-tab.md | ✅Succeeded | View | |
| msteams-platform/tabs/how-to/using-teams-client-sdk.md | ✅Succeeded | View | |
| msteams-platform/task-modules-and-cards/cards/cards-format.md | ✅Succeeded | View |
msteams-platform/build-your-first-app/build-and-run.md
- Line 66, Column 103: [Warning-file-not-found]
Invalid file link: '~/tutorials/get-started-dotnet-app-studio.md/'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:
- Try searching the docs.microsoft.com contributor guides
- Post your question in the Docs support channel
|
Docs Build status updates of commit c69b919: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 0fd050a: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 09e4581: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit bc3adbd: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit bc3adbd: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit f5c0571: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit f5c0571: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Added link to Tunnel using ngrok
|
Docs Build status updates of commit e36c63f: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
surbhigupta12
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Create a Hello World" section revamp