Document fontWeight setting #26
Assignees
Labels
documentation
Improvements or additions to documentation
futureRelease
This is releated to a future version that has not yet been release via Microsoft Store
Comments
6 tasks
ghost
pushed a commit
to microsoft/terminal
that referenced
this issue
May 20, 2020
## Summary of the Pull Request Adds the ability to specify the font weight in the profiles, right next to the size and the font face. ## PR Checklist * [x] Closes #1751 * [x] I work here. * [x] Tested manually, see below. * [x] Added documentation to the schema * [x] Requires docs.microsoft.com update, filed as MicrosoftDocs/terminal#26 * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Weights can be specified according to the OpenType specification values. We accept either the friendly name or the numerical value that applies to each weight. - Weights are carried through per-profile and sent into the renderer. - Weights are carried through to the TSF/IME overlay. - The names are restricted to the set seen at https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweights. - There are alternate names at https://docs.microsoft.com/en-us/windows/win32/api/dwrite/ne-dwrite-dwrite_font_weight for the same values (ultra-black is just an alias for extra-black at 950). ## Validation Steps Performed - Cascadia Code normal  - Cascadia Code bold  - Segoe UI Semilight  - Segoe UI Black  - Segoe UI 900 (value for Black) 
|
Hmm... @miniksa ...this doesn't seem to be working for me.
|
|
@mattwojo Yea, that setting only got added in microsoft/terminal#6048, which won't be released until 1.1 comes out. Do you know what are plan is for adding settings like this? Like, until there's a release with the setting, we can't really say "new in v1.1.rev.0", since we won't know what the version will be, right? |
|
@zadjii-msft -- I think we should try to align doc updates with official releases available via Microsoft Store. Thoughts? |
mattwojo
added
documentation
|
That makes sense to me. Maybe as we work on each release, we should have one docs branch for all the in-flight features, that the team can collectively make PRs into for features as we add them, and on release merge that docs branch into master. |
|
Yes! Love this workflow. Does the branch naming convention: "release-v1.1" make sense? Or should we use something different? If that works, I'll create it now. |
jelster
pushed a commit
to jelster/terminal
that referenced
this issue
May 28, 2020
## Summary of the Pull Request Adds the ability to specify the font weight in the profiles, right next to the size and the font face. ## PR Checklist * [x] Closes microsoft#1751 * [x] I work here. * [x] Tested manually, see below. * [x] Added documentation to the schema * [x] Requires docs.microsoft.com update, filed as MicrosoftDocs/terminal#26 * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Weights can be specified according to the OpenType specification values. We accept either the friendly name or the numerical value that applies to each weight. - Weights are carried through per-profile and sent into the renderer. - Weights are carried through to the TSF/IME overlay. - The names are restricted to the set seen at https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweights. - There are alternate names at https://docs.microsoft.com/en-us/windows/win32/api/dwrite/ne-dwrite-dwrite_font_weight for the same values (ultra-black is just an alias for extra-black at 950). ## Validation Steps Performed - Cascadia Code normal  - Cascadia Code bold  - Segoe UI Semilight  - Segoe UI Black  - Segoe UI 900 (value for Black) 
This was referenced Jun 14, 2020
donno2048
added a commit
to donno2048/terminal
that referenced
this issue
Sep 28, 2020
## Summary of the Pull Request Adds the ability to specify the font weight in the profiles, right next to the size and the font face. ## PR Checklist * [x] Closes #1751 * [x] I work here. * [x] Tested manually, see below. * [x] Added documentation to the schema * [x] Requires docs.microsoft.com update, filed as MicrosoftDocs/terminal#26 * [x] I'm a core contributor. ## Detailed Description of the Pull Request / Additional comments - Weights can be specified according to the OpenType specification values. We accept either the friendly name or the numerical value that applies to each weight. - Weights are carried through per-profile and sent into the renderer. - Weights are carried through to the TSF/IME overlay. - The names are restricted to the set seen at https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweights. - There are alternate names at https://docs.microsoft.com/en-us/windows/win32/api/dwrite/ne-dwrite-dwrite_font_weight for the same values (ultra-black is just an alias for extra-black at 950). ## Validation Steps Performed - Cascadia Code normal  - Cascadia Code bold  - Segoe UI Semilight  - Segoe UI Black  - Segoe UI 900 (value for Black) 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://docs.microsoft.com/en-us/windows/terminal/customize-settings/profile-settings
See microsoft/terminal#6048 for impl.
The text was updated successfully, but these errors were encountered: