Add font weight options

[miniksa]

Summary of the Pull Request

Adds the ability to specify the font weight in the profiles, right next to the size and the font face.

PR Checklist

• Closes Add support for configuring Font Weight #1751
• I work here.
• Tested manually, see below.
• Added documentation to the schema
• Requires docs.microsoft.com update, filed as Document fontWeight setting MicrosoftDocs/terminal#26
• I'm a core contributor.

Detailed Description of the Pull Request / Additional comments

• Weights can be specified according to the OpenType specification values. We accept either the friendly name or the numerical value that applies to each weight.
• Weights are carried through per-profile and sent into the renderer.
• Weights are carried through to the TSF/IME overlay.
• The names are restricted to the set seen at https://docs.microsoft.com/en-us/uwp/api/windows.ui.text.fontweights.
• There are alternate names at https://docs.microsoft.com/en-us/windows/win32/api/dwrite/ne-dwrite-dwrite_font_weight for the same values (ultra-black is just an alias for extra-black at 950).

Validation Steps Performed

• Cascadia Code normal
  

• Cascadia Code bold
  

• Segoe UI Semilight
  

• Segoe UI Black
  

• Segoe UI 900 (value for Black)
  

[DHowett]

Is it time for us to move from fontFace to font{ face, weight, ... } or font{ family, weight ... }?

[mdtauk]

The problem I see with this option, is when they add support for Bold and Italic emphasis text. What happens if the bold weight of a font is already being used as the default weight?

Perhaps if there were three font settings, one for Normal, one for Bold, and one for Italic - then the user would be responsible for the choices?

[DHowett]

It's beautiful.

[DHowett]

@mdtauk

they

you mean we, right? 😁

[miniksa]

The problem I see with this option, is when they add support for Bold and Italic emphasis text. What happens if the bold weight of a font is already being used as the default weight?

Perhaps if there were three font settings, one for Normal, one for Bold, and one for Italic - then the user would be responsible for the choices?

I'm not going to hold back progress because this isn't perfect. We can't support bolding yet (which is #109). I do think that perhaps we can, at some future date, offer folks the choice of which presentation they want for any of those states, like you say, by offering a full font specification for each state. But we'll cross that bridge when we get to it.

[mdtauk]

@mdtauk

they

you mean we, right? 😁

Point taken, although I can't make heads nor tails of C and C++ code, so I await the talents of others.

[zadjii-msft]

Yea so this looks great. Maybe we do need to have a conversation about "font": { ... } vs "fontFace": "", "fontWeight":"", "lineSpacing":"", ..., but I think this is a fine start

[miniksa]

@DHowett asked me to try Fira Code variable weight font. So I did. And it works. But I made it so the numerical value can be specified anywhere from 100-990 so you can take advantage of the variableness.

[ghost]

Hello @miniksa!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 54 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[miniksa]

@msftbot wait 10 minutes before merging

[ghost]

Hello @miniksa!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I won't merge this pull request until after the UTC date Wed, 20 May 2020 20:17:08 GMT, which is in 10 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

[DHowett]

I can't sign off a second time, but pretend I did.

[mdtauk]

@DHowett asked me to try Fira Code variable weight font. So I did. And it works. But I made it so the numerical value can be specified anywhere from 100-990 so you can take advantage of the variableness.

If the font chosen is a Variable font, then the V2 Settings UI should probably display a slider for the weight value.

[tormento]

@miniksa which of the various web release Fira Code did you try? Official repository on GitHub? I tried to use "fontWeight": "300", on Terminal Preview 1.0.1402.0 but it has no effect.

[miniksa]

@tormento, I just checked this in 6 days ago. I don't believe we have released a build with this feature yet. Soon.

[tormento]

@miniksa in the mean time, could you address me to the Fira Code repository you used? I am using FiraCodeGX.ttf 4.0 from official repository on GitHub.

[miniksa]

@tormento I used the 4.0 release off of the GitHub repository tonsky/FiraCode. I took the file FiraCode-VF.ttf out of the variable_ttf folder in the zip.

[tormento]

@miniksa the VF variant doesn't show the major families, i.e. light, regular, medium, etc.

The GX one yes, at least on Windows 10 x64 19631.

[miniksa]

@tormento, OK? But it works. Either build master and try it or wait for a release please.

[tormento]

@miniksa yeah, yeah. It was just a hint about the two different versions 😇

[ghost]

🎉Windows Terminal Preview v1.1.1671.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download